Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide/Show (Un)Deprecate Button for package owner only #10091

Merged
merged 6 commits into from
Oct 31, 2019

Conversation

zeusongit
Copy link
Contributor

@zeusongit zeusongit commented Oct 28, 2019

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

Deprecate/Undeprecate button should only be active for the author of the package.
DYN-1876: https://jira.autodesk.com/browse/DYN-1876

deprecate-btn

Declarations

Check these if you believe they are true

  • The code base is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning, and are documented in the API Changes document.

Reviewers

@DynamoDS/dynamo

FYIs

@mjkkirschner
Copy link
Member

mjkkirschner commented Oct 28, 2019

@zeusongit thanks for the quick work on this one -
please consider the comments above and in addition it would be good to add:

  • a test if possible (mocked data is good)
  • gif of the changes to the UI

…lass and pre check for authorisation required before ownership check
@QilongTang
Copy link
Contributor

LGTM

@QilongTang
Copy link
Contributor

:shipit:

@QilongTang QilongTang added the LGTM Looks good to me label Oct 31, 2019
@QilongTang QilongTang merged commit d7e45e2 into DynamoDS:master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LGTM Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants