Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Weird space added when making link to zettle #30

Closed
2 tasks done
Eforen opened this issue Sep 9, 2022 · 2 comments
Closed
2 tasks done

[BUG] Weird space added when making link to zettle #30

Eforen opened this issue Sep 9, 2022 · 2 comments
Assignees
@Eforen
Labels
bug Something isn't working
Milestone
1.1.4

Comments

@Eforen
Copy link
Collaborator

Eforen commented Sep 9, 2022

Issue Searching

  • I have searched for similar issues that are open.
  • I have searched for similar issues that are closed.

OtherIssues

No other similar issues closed or open.

Description

Making a new Child or Sibling the link left behind always has a space before it no mater what.

Reproduction steps

  1. Go to a note for example 1⁝ Root
  2. Type in ""
  3. Place cursor between the 2 "
  4. Run the Luhman: New Child Zettel Note CMD
  5. Type the title Test
  6. Go back to the original note

Expected Result

"[[1a⁝ Root]]"

Actual Result

" [[1a⁝ Root]]"

Version

1.1.1 (Prerelease Built from Source)

Relevent log output

No response

Screenshots

No response

Other Notes

No response
@Eforen Eforen added the bug Something isn't working label Sep 9, 2022
@Eforen Eforen assigned Eforen and brannonh and unassigned brannonh Sep 9, 2022
Eforen added a commit that referenced this issue Sep 10, 2022
@Eforen
Fix Bugs relating to Child and Sibling Creation
7125f96 
- Fixed [BUG] On Create Sibling or Child Note, link to child or sibling incorrect #24
- Fixed [BUG] Weird space added when making link to zettle
#30
@Eforen Eforen mentioned this issue Sep 10, 2022
Merged
@jvanz jvanz modified the milestones: 1.2.0, 1.1.1 Sep 10, 2022
@Eforen
Copy link
Collaborator Author

Eforen commented Sep 10, 2022

This should be mostly fixed in PR #31 there is a second weirder bug that will still be open that has is similar but I am considering a different issue #32 in that one it's not just a space but weird placement and things left behind its a whole thing. Planning on trying to work on that today.

@Eforen
Copy link
Collaborator Author

Eforen commented Sep 11, 2022

Resolved by #31

@Eforen Eforen closed this as completed Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Eforen Eforen

Labels
bug Something isn't working
Projects
None yet
Milestone
1.1.4
Development

No branches or pull requests
3 participants
@Eforen @jvanz @brannonh