Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] On Create Sibling or Child Note, link to child or sibling incorrect #24

Closed
jamesx4 opened this issue Sep 9, 2022 · 5 comments
Closed
Assignees
Labels
bug Something isn't working duplicate This issue or pull request already exists
Milestone

Comments

@jamesx4
Copy link

jamesx4 commented Sep 9, 2022

When creating a child or sibling note with Add titles automatically enabled, the link on originating note only contains the Luhman ID, but no title. The new child or sibling note has the correct <title> for the filename, but the link from originating page only has . So when you click the link on the originating page it takes you to a new note, not the actual child note that was created.

@jamesx4 jamesx4 changed the title On Create Sibling or Child Note, link to child or sibling incorrect [BUG] On Create Sibling or Child Note, link to child or sibling incorrect Sep 9, 2022
@Eforen
Copy link
Collaborator

Eforen commented Sep 9, 2022

I believe this is a duplicate of #17 and #6 and resolved by #9

@Eforen
Copy link
Collaborator

Eforen commented Sep 9, 2022

For now I am closing this issue as it will be in the upcoming version see the roadmap issue for more information.
( #19 )

If after we get this update out you still see the problem please feel free to reopen it.

That said this exact issue is why I became one of the mantainers of this project so I will be confirming this is fixed in the upcoming release for sure.

@Eforen Eforen closed this as completed Sep 9, 2022
@Eforen Eforen added the duplicate This issue or pull request already exists label Sep 9, 2022
@Eforen
Copy link
Collaborator

Eforen commented Sep 9, 2022

Reopening this issue because its still not fixed just tested current codebase

@Eforen Eforen reopened this Sep 9, 2022
@Eforen Eforen self-assigned this Sep 9, 2022
Eforen added a commit that referenced this issue Sep 10, 2022
- Fixed [BUG] On Create Sibling or Child Note, link to child or sibling incorrect #24
- Fixed [BUG] Weird space added when making link to zettle
#30
@Eforen
Copy link
Collaborator

Eforen commented Sep 10, 2022

This should be fixed in PR #31

@Eforen Eforen added this to the 1.1.1 milestone Sep 10, 2022
@Eforen Eforen added the bug Something isn't working label Sep 10, 2022
@Eforen
Copy link
Collaborator

Eforen commented Sep 11, 2022

Resolved by #31

@Eforen Eforen closed this as completed Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants