-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Integrate navigation drawer #653
Feature: Integrate navigation drawer #653
Conversation
…d using an application context object. This avoids memory allocation for the creation of the UiLanguage object, and prevent possible leakage of Activity object, as only an application context is needed to make the config update.
…e app. UI is in place. Needs to tie functionality.
…ngly. Turned the 'HelpActivity' abstract class into an interface. Help dialog is provider by 'org.droidplanner.activities.helpers.HelpDialogFragment'.
For now the 'Drone Setup' user interface was left unchanged. |
I haven't run it yet (working on the decoupling branch), but the screenshots look great. I like the settings menu, with app settings in the parent activity. This makes us a lot closer to the Android design guidelines, which is nice. Do you want to work more on this or should I merge it? |
I wanted to get @jason4short 's feedback regarding the drawer's look, but it's good to merge as is. |
But feel free to go ahead and merge it. |
Looks good. |
Just tested it and it works very well. I'm just thinking that the editor should receive a promotion to top at the navigation hierarchy. |
Feature: Integrate navigation drawer
@arthurbenemann the |
Good point. I would like to promote the Editor, but that shortcut button really implies a child in the hierarchy. @jason4short Any comment's on this issue? |
Updated the app to use the navigation drawer for primary navigation: