Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Integrate navigation drawer #653

Merged
merged 4 commits into from
Feb 25, 2014

Conversation

m4gr3d
Copy link
Member

@m4gr3d m4gr3d commented Feb 24, 2014

Updated the app to use the navigation drawer for primary navigation:

portrait_collapsed
portrait_expanded
landscape_collapsed
landscape_expanded

…d using an application context object. This avoids memory allocation for the creation of the UiLanguage object, and prevent possible leakage of Activity object, as only an application context is needed to make the config update.
…e app. UI is in place. Needs to tie functionality.
…ngly.

Turned the 'HelpActivity' abstract class into an interface. Help dialog is provider by 'org.droidplanner.activities.helpers.HelpDialogFragment'.
@m4gr3d
Copy link
Member Author

m4gr3d commented Feb 24, 2014

As a side effect to the ui update, the 'Settings' and 'Drone Setup' sections were merged together. The 'Settings' is now the parent activity, and 'Drone Setup' is launched from the 'Settings' screen:

new_settings_1
new_settings_2

@m4gr3d
Copy link
Member Author

m4gr3d commented Feb 24, 2014

For now the 'Drone Setup' user interface was left unchanged.
I'm awaiting feedback from @DroidPlanner @arthurbenemann and @jason4short as this could be the first step toward completing @jason4short 'Drone Settings rework' issue (issue #626).

@arthurbenemann
Copy link
Member

I haven't run it yet (working on the decoupling branch), but the screenshots look great. I like the settings menu, with app settings in the parent activity. This makes us a lot closer to the Android design guidelines, which is nice.

Do you want to work more on this or should I merge it?

@m4gr3d
Copy link
Member Author

m4gr3d commented Feb 24, 2014

I wanted to get @jason4short 's feedback regarding the drawer's look, but it's good to merge as is.
Also now, the menu only contains activity's specific action items. All the navigation was moved to the drawer.

@m4gr3d
Copy link
Member Author

m4gr3d commented Feb 24, 2014

But feel free to go ahead and merge it.

@jason4short
Copy link
Contributor

Looks good.
Maybe we should also change the Edit icon on the bottom to say "Editor" like your panel shows.
Jason

@arthurbenemann
Copy link
Member

Just tested it and it works very well.

I'm just thinking that the editor should receive a promotion to top at the navigation hierarchy.

arthurbenemann added a commit that referenced this pull request Feb 25, 2014
@arthurbenemann arthurbenemann merged commit efc6598 into DroidPlanner:master Feb 25, 2014
@m4gr3d
Copy link
Member Author

m4gr3d commented Feb 25, 2014

@arthurbenemann the FlightActivity 'Edit' button implies the 'Editor' activity is a subsection of the 'Flight Data' activity, hence its place in the navigation drawer. If the editor is promoted to the top, will it still be accessible via the 'Edit' button?

@arthurbenemann
Copy link
Member

Good point. I would like to promote the Editor, but that shortcut button really implies a child in the hierarchy.

@jason4short Any comment's on this issue?

@m4gr3d m4gr3d deleted the feature_drawer_navigation branch March 10, 2014 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants