Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦️ Update the npm package + add rolebutton #155

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

Drlanderf
Copy link
Owner

No description provided.

@Drlanderf Drlanderf added feature ✨Introduce new features. patch labels Feb 18, 2024
@Drlanderf Drlanderf self-assigned this Feb 18, 2024
@Drlanderf Drlanderf linked an issue Feb 18, 2024 that may be closed by this pull request
@Drlanderf Drlanderf merged commit ecd91d8 into release Feb 18, 2024
1 check passed
@Drlanderf Drlanderf deleted the 154-add-some-rolebutton-for-the-main-server branch February 18, 2024 15:36
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Enhancement

PR Summary: This pull request introduces enhancements to the rolebutton functionality within the application. It adds new buttons for additional roles, specifically for the games 'Skull and Bones' and 'Crossout', and organizes these buttons into a new row within the user interface. Additionally, it updates the embed message to include information about these new game roles, ensuring users are aware of the options available to them.

Decision: Comment

📝 Type: 'Enhancement' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
  • Unsupported files: the diff contains files that Sourcery does not currently support during reviews.

General suggestions:

  • Consider reviewing the consistency of indentation across the changes to ensure the code style remains uniform.
  • Verify the emoji usage for the new buttons to ensure they are intuitive and representative of the respective games.
  • Ensure that the addition of new roles and the corresponding UI changes have been communicated to the end-users, if necessary, to avoid confusion.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ✨Introduce new features. patch
Projects
Development

Successfully merging this pull request may close these issues.

Add some rolebutton for the main server
1 participant