-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrades ember-app-scheduler to 1.0.1 #139
Conversation
Also, @rwjblue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this branch out on our project and works perfectly 👍 . FYI - I think the way to generate a new release this is to change the version in the package.json. So 0.7.1
or something like that.
For sure. Usually I let the library owners handle the bumping of the version etc. Glad it worked for you! |
Anything else I need to do to get this merged? |
@scalvert I think once the version is bumped in the Also @ryanto might be interested in this PR to try out. |
Done! |
Thanks! This is working so far locally and in CI. 🎉 From the readme I'm having some trouble understanding when I should and shouldn't use |
Ah ok! Thanks |
The first major release of ember-app-scheduler is out, and includes a rewrite of the existing API. This PR bumps the version to the latest, and upgrades the API usage to the new API.
This PR supersedes #129 and #138