Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades ember-app-scheduler to 1.0.1 #139

Merged
merged 2 commits into from
Jun 11, 2018

Conversation

scalvert
Copy link
Contributor

@scalvert scalvert commented May 31, 2018

The first major release of ember-app-scheduler is out, and includes a rewrite of the existing API. This PR bumps the version to the latest, and upgrades the API usage to the new API.

This PR supersedes #129 and #138

@scalvert
Copy link
Contributor Author

@Turbo87 @snewcomer

@scalvert
Copy link
Contributor Author

Also, @rwjblue

Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this branch out on our project and works perfectly 👍 . FYI - I think the way to generate a new release this is to change the version in the package.json. So 0.7.1 or something like that.

@scalvert
Copy link
Contributor Author

For sure. Usually I let the library owners handle the bumping of the version etc.

Glad it worked for you!

@scalvert
Copy link
Contributor Author

Anything else I need to do to get this merged?

@snewcomer
Copy link
Collaborator

snewcomer commented Jun 11, 2018

@scalvert I think once the version is bumped in the package.json (see issue comment below), @yowainwright can merge && publish a new release if he approves.

Also @ryanto might be interested in this PR to try out.

#132 (comment)

@scalvert
Copy link
Contributor Author

Done!

@yowainwright yowainwright merged commit f88e8b7 into DockYard:master Jun 11, 2018
@ryanto
Copy link
Contributor

ryanto commented Jun 11, 2018

Thanks! This is working so far locally and in CI. 🎉

From the readme I'm having some trouble understanding when I should and shouldn't use delayScrollTop? Seems like the answer would mostly be yes? Are there situations where I wouldn't want delayScrollTop...?

@snewcomer
Copy link
Collaborator

@ryanto I would say you don't want delayScrollTop. Removing this as the default has now avoided any page flashes when transitioning b/w routes. This was also seen in the dummy app...

#101

@ryanto
Copy link
Contributor

ryanto commented Jun 11, 2018

Ah ok! Thanks

@scalvert scalvert deleted the upgrade-app-scheduler branch July 9, 2018 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants