Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - update app scheduler #138

Closed
wants to merge 2 commits into from

Conversation

snewcomer
Copy link
Collaborator

A WIP. Will point when things seems stable or 1.0 is released. Using it to test for now.

@snewcomer snewcomer force-pushed the update-app-scheduler branch from 40f7c67 to 8a4d18d Compare May 31, 2018 14:49
@snewcomer snewcomer force-pushed the update-app-scheduler branch from 8a4d18d to c676d23 Compare May 31, 2018 14:50
@scalvert
Copy link
Contributor

@snewcomer I was literally just publishing the new app-scheduler, and am opening a PR to update it once that's done. Do you want me to just update this PR?

@snewcomer
Copy link
Collaborator Author

nice! Thank you 🙏 I can update later today to save you the time of pulling down my branch.

@scalvert
Copy link
Contributor

I have a branch ready with the changes. Would it be easier if I just opened that PR instead and we can close this one?

@snewcomer
Copy link
Collaborator Author

sure. Sounds like there are some API updates?

@scalvert
Copy link
Contributor

Yep. Basically the entire API has changed :). The surface area of the API wasn't large to start with, but now it's more explicit. Additionally, it doesn't use a bunch of threaded queuing and promises to achieve what we want. It's just using promises that are interleaved with rAF+macro tasks. It's also way more thoroughly tested.

@snewcomer snewcomer closed this May 31, 2018
@scalvert
Copy link
Contributor

I have my branch working, and all the tests passing (with a few tweaks). Will be opening my PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants