Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OBO MykoMap] Support explicit configurabilty of field used in Directory panel #237

Closed
ColmDC opened this issue Mar 8, 2024 · 4 comments
Labels
billable Work against a grant of for a client

Comments

@ColmDC
Copy link
Contributor

ColmDC commented Mar 8, 2024

Please track against the clockify project [OBO MykoMap]

Description

Add the ability to explicitly specify what field is used in Directory panel in the map configuration. At the moment it is implicit and assumed to be the top field displayed in the Search panel. Implementation needs to be backwards compatible, and if no configuration specified, the top field in the filter is defines the choice of field in the Directory panel.

Acceptance Criteria

@ColmDC ColmDC added the billable Work against a grant of for a client label Mar 8, 2024
@ColmDC ColmDC changed the title Support explicit configurabilty of field used in Directory panel [OBO MykoMap] Support explicit configurabilty of field used in Directory panel Mar 25, 2024
@ColmDC
Copy link
Contributor Author

ColmDC commented Mar 29, 2024

While addressing this consider what would happen if there are no filters defined.
It may cause an exception.
Is it possible to disable the directory panel?

@lin-d-hop
Copy link

Hi @ColmDC,

A couple notes:

  • The Acceptance Criteria sound more like testing notes. The actual acceptance criteria are dotted throughout the text.
  • Its super helpful to give a little background. At least it helps me to unpack the jargon a bit faster.

Does the below correctly interpret what you've said?

##Description
Within MM the Directory panel is an expanded version of the first filter in the Search panel. In this issue we want to make it possible to specify another filter, besides the first one, as the filter to be expanded in the Directory panel. The goal is the create a new field that allows any of the filters from the Search panel to be selected, which can be specified in the MM config file.

##Acceptance Criteria

  • Create an addition MM configuration option enabling a specified filter to be selected. This could be done by specifying an integer or text string, ideally readable yet flexible for any case.
  • If this configuration is missing or throws an error, the default should be the first specified filter as now
  • Ensure backwards compatibility with all MM (hopefully handled by the above)
  • Ensure the case that no filters are defined is handled. Possibly by also not showing the directory. Or whatever happens now (ie backwards compatibility).

@ColmDC
Copy link
Contributor Author

ColmDC commented May 13, 2024

Perfect. Has anyone even mentioned that you are good at this @lin-d-hop?

@lin-d-hop
Copy link

Replaced by #248 (to save the time of other people reading through the comments)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
billable Work against a grant of for a client
Projects
None yet
Development

No branches or pull requests

2 participants