Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OBO MykoMap] Return OBO MM configuration to use Primary Activity as the Primary Directory vocabulary #235

Closed
ColmDC opened this issue Feb 17, 2024 · 11 comments
Assignees
Labels
billable Work against a grant of for a client

Comments

@ColmDC
Copy link
Contributor

ColmDC commented Feb 17, 2024

Please track against the clockify project [OBO MykoMap]

Description

Change OBO MM configuration to use Primary Activity as the Directory vocabulary while leaving Nature of Organisation as the top filter option.

Acceptance Criteria

@ColmDC
Copy link
Contributor Author

ColmDC commented Feb 17, 2024

Was there a problem with using Primary Activities for the Primary Directory?

@lin-d-hop
Copy link

This is cryptic to an outsider. I wonder if we can add any supportive detail, or link to anywhere in which this jargon is explained?

@wu-lee
Copy link
Contributor

wu-lee commented Feb 26, 2024

(Is this specifically a Mykomap issue? Seems like this is in the wrong project - the work for this was done as a part of this issue DigitalCommons/owned-by-oxford-project#26)

Just to be clear, I'm referring to this map: https://dev.maps.solidarityeconomy.coop/obo-public/

There the "Nature Of" field is being used on the directory panel. IIRC we were asked to use that as the first field in the filter list (see issue 26 above) because they wanted it to be the first one people see. And the consequence of that is that it is also the one used for the directory panel (a design choice made in Mykomap's deep history). I think this was mentioned in the google documents I tried to summarise in that issue 26, although I can't find this mentioned in the issue specifically... I also recall pointing out this would be a consequence, and it would look strange because that field's taxonomy (AKA vocab) has only two values.

As an aside - we were also asked to combine "Primary Activity" and "Secondary Activities" into a single field, so users can search for them as one thing. This field happens to be called "Combined Activities", and of course allows multiple values in the field. If we do want to show activities instead, possibly that deserves to be in the directory rather than "Primary Activity". (Multi-value fields will be a problem for pin icons/colours however.)

@ColmDC
Copy link
Contributor Author

ColmDC commented Feb 27, 2024

(Is this specifically a Mykomap issue? Seems like this is in the wrong project - the work for this was done as a part of this issue DigitalCommons/owned-by-oxford-project#26)

There is a motivation to move away from having as many repositories as we have. So if an issue is a generic MM issue, even if it arises through a specific project, we can manage it as an issue in the main repository. But this issue does seem to be very local to the OBO project. At some point we will not need repositories for each project and we will need to have a different protocol for tagging project specific issues.

@ColmDC
Copy link
Contributor Author

ColmDC commented Feb 27, 2024

@lin-d-hop we will just clarify the issue with @nick in the comments and then rephrase the Issue description.

IIRC we were asked to use that as the first field in the filter list (see issue 26 above) because they wanted it to be the first one people see. And the consequence of that is that it is also the one used for the directory panel (a design choice made in Mykomap's deep history).

I recall now. @wu-lee Can you recall if that connection between the first filter item and choice of Primary directory category would be hard to seperate?

@ColmDC
Copy link
Contributor Author

ColmDC commented Feb 27, 2024

This field happens to be called "Combined Activities", and of course allows multiple values in the field. If we do want to show activities instead, possibly that deserves to be in the directory rather than "Primary Activity". (Multi-value fields will be a problem for pin icons/colours however.)

If we did this, I can't see why there would need to be any changes to the use of colours? Pin colour remains hardwired to Primary Activity? But what we will loose is the colour key, as in the old map the key was provided by a coloured bar beside the name of the Primary Activiity in the Directory Panel.
Owned-by-Oxford

We also do not have that implicit key to the pin colours if we have Nature of Organisation in the Directory panel.

Owned-by-Oxford-Nature

@wu-lee
Copy link
Contributor

wu-lee commented Mar 4, 2024

If we did this, I can't see why there would need to be any changes to the use of colours? Pin colour remains hardwired to Primary Activity? But what we will loose is the colour key, as in the old map the key was provided by a coloured bar beside the name of the Primary Activiity in the Directory Panel.

Agreed, pins would still be coloured as you say, but we'd lose colours on the directory if it weren't a single-valued economic activity.

We also do not have that implicit key to the pin colours if we have Nature of Organisation in the Directory panel.

Agreed.

Can you recall if that connection between the first filter item and choice of Primary directory category would be hard to seperate?

Not that hard, but it would need inventing some alternative way to define it. Possibly some new field in the config, to allow backward compatibility and a way to specify this option in the URL parameters easily; alternatively perhaps allowing the things in the filterableFields list to be objects in the general case, which might also allow for more flexibility in future, e.g. setting other values like the default filter value, which is something else we have an issue for (although not one I can currently locate). At the expense of ease of URL-parametering. (I currently tend towards the latter, URL parameters are problematic anyway.)

@ColmDC
Copy link
Contributor Author

ColmDC commented Mar 5, 2024

"

Can you recall if that connection between the first filter item and choice of Primary directory category would be hard to seperate?

Not that hard, but it would need inventing some alternative way to define it. Possibly some new field in the config, to allow backward compatibility and a way to specify this option in the URL parameters easily; alternatively perhaps allowing the things in the filterableFields list to be objects in the general case, which might also allow for more flexibility in future, e.g. setting other values like the default filter value, which is something else we have an issue for (although not one I can currently locate). At the expense of ease of URL-parametering. (I currently tend towards the latter, URL parameters are problematic anyway.)"

So I think this requires a new ticket on its own. Let's move this ticket back down the list until this new issue is completed.

@ColmDC
Copy link
Contributor Author

ColmDC commented Mar 8, 2024

Return to this when #237 has been implemented.

@ColmDC ColmDC added billable Work against a grant of for a client blocked Can't be progressed until another Issue has been completed labels Mar 8, 2024
@ColmDC
Copy link
Contributor Author

ColmDC commented Mar 8, 2024

I've tagged is as blocked, but I think its requirements are no clear (and easy once #237 is implemented) so moving to Backlog.

@ColmDC ColmDC changed the title Return OBO MM configuration to use Primary Activity as the Primary Directory vocabulary [OBO MykoMap] Return OBO MM configuration to use Primary Activity as the Primary Directory vocabulary Mar 20, 2024
@ColmDC ColmDC self-assigned this May 13, 2024
@ColmDC
Copy link
Contributor Author

ColmDC commented Jun 28, 2024

I've tagged is as blocked, but I think its requirements are no clear (and easy once #237 is implemented) so moving to Backlog.

#237 is now implemented, so it should be just a matter of changing the configurations.

@ColmDC ColmDC removed the blocked Can't be progressed until another Issue has been completed label Jun 28, 2024
@ColmDC ColmDC closed this as completed Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
billable Work against a grant of for a client
Projects
None yet
Development

No branches or pull requests

3 participants