-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Co-ops UK Map data with latest interim drop #19
Comments
Set date in about box to reflect date of drop i.e 2023-05-15. Also add this logo https://upload.wikimedia.org/wikipedia/en/thumb/2/21/Co-operatives_UK_logo-2015.png/225px-Co-operatives_UK_logo-2015.png |
The headings in the CSV has changed. Attempting to match them up I can get all of the important ones bar one: "SIC Sector", which has no equivalent in the new data, either looking at the name or looking at the content. The But I think I can infer the SIC Section from the old data, by mapping SIC Codes to SIC Section. Will see if this works shortly. Matches below.
|
I've had to add some SIC code mappings. Most of these fall in blocks of mappings to the same SIC section label, which make it reasonably straightforward to guess. The remaining few I've mapped to null, which is what some codes are mapped to in the previous dataset. Otherwise, this conversion seems to work. (NI postcodes notwithstanding) Need to see how much it's changed on the map next. |
Have deployed a the data but kept a local copy of the old standard.csv. Have updated the date on the the "about" panel of the co-ops UK map to Q2-2023. Note to self - ideally we wouldn't need to do that, it should be a property of the data shown in the map, so if the data changes we don't need to choose between out of data information on the map, and a rebuild and redeploy of exactly the same code but with correct information. Need to create an issue for this. |
Small changes from the previous version are not a problem as it was not a version publically promoted. I'll do some manual testing. |
They are going to change how they approach publishing this data after the summer, and we should have an opportunity to influence those changes. |
Ok. Note, this will be a problem anywhere we want to say "this data is version X" in the "about" dialog, because the about text is versioned with the map site and not the data (or mykomap). Issue here: DigitalCommons/mykomap#209 |
Note, the map has also been bumped to mykomap 3.0.6 |
Create a ticket to come back at some point and compare the location differences. |
It seems unlikely that this is caused by new data, but the search panel doesn't open in https://dev.coopsuk.solidarityeconomy.coop/ |
Hard to QA this any further with this bug. |
Created own issue for this bug #21 |
This data has a different schema. It needs a new schema.yml file, and a mapping tabel to re-generate the "SIC Section" field from the SIC Code, as the former is absent but can mostly be deduced from the SIC Code->SIC section mapping in the previouos data. However, some mapping entries needed to be added with a bit of guesswork. See DigitalCommons/coopsuk#19
The data in https://dev.data.solidarityeconomy.coop/coops-uk/ is from the last public open data drop by Co-ops UK. They have postponed doing public drops for a while, as they decided to review their whole approach to it. However, they have provided us with an iterim drop which can be found here.
Update our published data to use this new iteration.
The text was updated successfully, but these errors were encountered: