Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search panel not opening #21

Closed
ColmDC opened this issue Jun 13, 2023 · 2 comments
Closed

Search panel not opening #21

ColmDC opened this issue Jun 13, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@ColmDC
Copy link
Contributor

ColmDC commented Jun 13, 2023

Describe the bug
The search panel is not opening properly

To Reproduce
Steps to reproduce the behavior:

  1. Open https://dev.coopsuk.solidarityeconomy.coop/
  2. Click on search tab

Expected behavior
The drop down filter options should appear below the search text box.

Screenshots

Search panel not opening properly

Desktop (please complete the following information):

  • OS: Window 10
  • Browser Firefox - Version [e.g. 22]
@wu-lee
Copy link

wu-lee commented Jun 13, 2023

Discovered something like this independently. If you open the browser console, I expect you'll see an error saying such and such field can't be in filterableFields because it's not a vocab.

Such-and-such being one or all of cukSector, sicSection and locality.

Two solutions to this - well, four:

  • take out those fields from filtereableFields, have primaryActivity as the first and therefore the directory field.
  • revert the mykomap version to 3.0.4
  • alter mykomap to either implement the use of non-vocab (i.e. ad hoc) vocabs, or
  • alter it to silently drop them from the filters, as 3.0.4 does. This at least allows the directory to show adhoc vocabs. (Tantamount to option 2.)

I've gone for the first one for the moment, should now be redeployed. Which do you prefer?

@ColmDC
Copy link
Contributor Author

ColmDC commented Jun 14, 2023

take out those fields from filtereableFields, have primaryActivity as the first and therefore the directory field.

That is fine for now. We can schedule to do "alter mykomap to either implement the use of non-vocab (i.e. ad hoc) vocabs" later. DigitalCommons/mykomap#201

@ColmDC ColmDC closed this as completed Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants