fix: display correct name for operations with fragments #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spawnia
requested changes
Nov 14, 2021
Co-authored-by: Benedikt Franke <[email protected]>
|
bump? |
spawnia
changed the title
mellisdesigns
deleted the
bug/support-query-strings-which-include-fragments
branch
github-actions bot
pushed a commit
that referenced
this pull request
Feb 27, 2022
## [3.0.3](v3.0.2...v3.0.3) (2022-02-27) ### Bug Fixes * display correct name for operations with fragments ([#411](#411)) ([6b759b9](6b759b9)) * include errors in breadcrumbs starting with the first ([0d272ce](0d272ce)) * include partial GraphQL errors in breadcrumbs ([#410](#410)) ([a3d929d](a3d929d)) ### Performance Improvements * avoid repeated property accesses in SentryLink.ts ([#422](#422)) ([b32e4f5](b32e4f5))
|
🎉 This PR is included in version 3.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently when fetching the operation we take the first operation found. This can include fragments defined at the top of the query string which ends up with the wrong operation name and query
Approach
Find the first
OperationDefinitionand return that (this filters out fragment types but keeps mutations and queries which are still validated as a single definition in one operation string)Example of the fragment returned instead of the query