Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include partial GraphQL errors in breadcrumbs #410

Merged
merged 3 commits into from
Dec 16, 2021

Conversation

repl-sarath
Copy link
Contributor

@repl-sarath repl-sarath commented Oct 27, 2021

@DiederikvandenB
Looks like there is a minor bug where the error is not included on partial error.
The level is set here

(breadcrumb as GraphQLBreadcrumb).level = severityForResult(result);

But the error is not. Please validate this PR

@spawnia spawnia changed the title Fix include error when partial error fix: include partial GraphQL errors in breadcrumbs Dec 16, 2021
@spawnia spawnia merged commit a3d929d into DiederikvandenB:master Dec 16, 2021
github-actions bot pushed a commit that referenced this pull request Feb 27, 2022
## [3.0.3](v3.0.2...v3.0.3) (2022-02-27)

### Bug Fixes

* display correct name for operations with fragments ([#411](#411)) ([6b759b9](6b759b9))
* include errors in breadcrumbs starting with the first ([0d272ce](0d272ce))
* include partial GraphQL errors in breadcrumbs ([#410](#410)) ([a3d929d](a3d929d))

### Performance Improvements

* avoid repeated property accesses in SentryLink.ts ([#422](#422)) ([b32e4f5](b32e4f5))
@github-actions
Copy link

🎉 This PR is included in version 3.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

erickreutz pushed a commit to lugg/apollo-link-sentry that referenced this pull request Feb 4, 2025
erickreutz pushed a commit to lugg/apollo-link-sentry that referenced this pull request Feb 4, 2025
## [3.0.3](DiederikvandenB/apollo-link-sentry@v3.0.2...v3.0.3) (2022-02-27)

### Bug Fixes

* display correct name for operations with fragments ([DiederikvandenB#411](DiederikvandenB#411)) ([6b759b9](DiederikvandenB@6b759b9))
* include errors in breadcrumbs starting with the first ([0d272ce](DiederikvandenB@0d272ce))
* include partial GraphQL errors in breadcrumbs ([DiederikvandenB#410](DiederikvandenB#410)) ([a3d929d](DiederikvandenB@a3d929d))

### Performance Improvements

* avoid repeated property accesses in SentryLink.ts ([DiederikvandenB#422](DiederikvandenB#422)) ([b32e4f5](DiederikvandenB@b32e4f5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants