-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: include partial GraphQL errors in breadcrumbs #410
Merged
spawnia
merged 3 commits into
DiederikvandenB:master
from
repl-sarath:includePartialErrorBug
Dec 16, 2021
Merged
fix: include partial GraphQL errors in breadcrumbs #410
spawnia
merged 3 commits into
DiederikvandenB:master
from
repl-sarath:includePartialErrorBug
Dec 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spawnia
requested changes
Nov 14, 2021
Narretz
reviewed
Dec 17, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Feb 27, 2022
## [3.0.3](v3.0.2...v3.0.3) (2022-02-27) ### Bug Fixes * display correct name for operations with fragments ([#411](#411)) ([6b759b9](6b759b9)) * include errors in breadcrumbs starting with the first ([0d272ce](0d272ce)) * include partial GraphQL errors in breadcrumbs ([#410](#410)) ([a3d929d](a3d929d)) ### Performance Improvements * avoid repeated property accesses in SentryLink.ts ([#422](#422)) ([b32e4f5](b32e4f5))
🎉 This PR is included in version 3.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
erickreutz
pushed a commit
to lugg/apollo-link-sentry
that referenced
this pull request
Feb 4, 2025
Co-authored-by: spawnia <[email protected]>
erickreutz
pushed a commit
to lugg/apollo-link-sentry
that referenced
this pull request
Feb 4, 2025
## [3.0.3](DiederikvandenB/apollo-link-sentry@v3.0.2...v3.0.3) (2022-02-27) ### Bug Fixes * display correct name for operations with fragments ([DiederikvandenB#411](DiederikvandenB#411)) ([6b759b9](DiederikvandenB@6b759b9)) * include errors in breadcrumbs starting with the first ([0d272ce](DiederikvandenB@0d272ce)) * include partial GraphQL errors in breadcrumbs ([DiederikvandenB#410](DiederikvandenB#410)) ([a3d929d](DiederikvandenB@a3d929d)) ### Performance Improvements * avoid repeated property accesses in SentryLink.ts ([DiederikvandenB#422](DiederikvandenB#422)) ([b32e4f5](DiederikvandenB@b32e4f5))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DiederikvandenB
Looks like there is a minor bug where the error is not included on partial error.
The level is set here
apollo-link-sentry/src/SentryLink.ts
Line 59 in 549037a
But the error is not. Please validate this PR