Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Item Lists for Inventory, Stash and Cube #106

Merged
merged 2 commits into from
Nov 11, 2020

Conversation

d2inventory
Copy link
Contributor

ItemInfo has a new field now (GUID), this is needed to identify removed items on update.

lars and others added 2 commits November 2, 2020 20:07
ItemInfo has a new field now (GUID), this is needed to identify removed items on update.
@Zutatensuppe Zutatensuppe self-requested a review November 11, 2020 20:52
Copy link
Collaborator

@Zutatensuppe Zutatensuppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 🦄

maybe at a later point we can replace iterating through inventory multiple times with a single iteration, because we are interested in all items anyway

@d2inventory
Copy link
Contributor Author

Yeah, I didn't put much effort into making the code good/nice.
As soon as I found the array containing the position of the items I was ready to rewrite it anyway.
But looks like getting a pointer to that array isn't that easy.

@Zutatensuppe Zutatensuppe merged commit f3b2753 into DiabloRun:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants