Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable Model updates #45

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Variable Model updates #45

merged 2 commits into from
Feb 10, 2023

Conversation

kaushalkapasi
Copy link
Contributor

No description provided.

This was referenced Feb 9, 2023
Merged
Merged
Merged
@kaushalkapasi Graphite App
Copy link
Contributor Author

kaushalkapasi commented Feb 9, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@kaushalkapasi Graphite App
Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@kaushalkapasi kaushalkapasi requested review from jonathannorris, ajwootto and a team February 9, 2023 23:22
@kaushalkapasi kaushalkapasi mentioned this pull request Feb 9, 2023
Merged
@kaushalkapasi kaushalkapasi force-pushed the add-sdk-key-verification branch from 85401bd to 39d0d9b Compare February 10, 2023 16:55
@kaushalkapasi kaushalkapasi force-pushed the fixes-for-variable-model branch from 5dc2cc2 to 8ce9eff Compare February 10, 2023 16:55
@kaushalkapasi kaushalkapasi force-pushed the add-sdk-key-verification branch from 39d0d9b to b50e343 Compare February 10, 2023 16:56
@kaushalkapasi kaushalkapasi force-pushed the fixes-for-variable-model branch from 8ce9eff to 4e805a1 Compare February 10, 2023 16:57
@kaushalkapasi
Variable model always returns type and defaultValue fields. remove un…
a7a831a 
…used reasonUsingDefault. update type enum from value to use fromClass
@kaushalkapasi kaushalkapasi force-pushed the add-sdk-key-verification branch from b50e343 to 5f2ff4b Compare February 10, 2023 17:49
@kaushalkapasi kaushalkapasi force-pushed the fixes-for-variable-model branch from 4e805a1 to a7a831a Compare February 10, 2023 17:49
@kaushalkapasi
add event type checking for track method in Local and Cloud clients. …
c818811 
…Cloud client return is now a void method that will not return on success
@kaushalkapasi kaushalkapasi merged commit 0e28345 into add-sdk-key-verification Feb 10, 2023
@kaushalkapasi kaushalkapasi deleted the fixes-for-variable-model branch February 10, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurawarr laurawarr laurawarr approved these changes

@jonathannorris jonathannorris Awaiting requested review from jonathannorris

@ajwootto ajwootto Awaiting requested review from ajwootto

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaushalkapasi @laurawarr