Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java SDK Test Harness bug fixes #42

Merged
merged 11 commits into from
Mar 1, 2023
Merged

Java SDK Test Harness bug fixes #42

merged 11 commits into from
Mar 1, 2023

Conversation

kaushalkapasi
Copy link
Contributor

@kaushalkapasi kaushalkapasi commented Feb 9, 2023 •
edited
Loading

  • Fix build.gradle to properly publish files to maven repository using gradle 7.5.1
    • Now also builds / publishes "module" version of the SDK
    • adds SHA256 and SHA512 signing
  • Add Unit Test GH Action workflow

@kaushalkapasi Graphite App
Copy link
Contributor Author

kaushalkapasi commented Feb 9, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

This was referenced Feb 9, 2023
Merged
Merged
Merged
Merged
@kaushalkapasi kaushalkapasi force-pushed the test-harness-fixes branch 3 times, most recently from dfd62af to f6c4e0f Compare February 10, 2023 17:49
@chantalchung chantalchung mentioned this pull request Feb 21, 2023
Closed
@kaushalkapasi kaushalkapasi force-pushed the test-harness-fixes branch 2 times, most recently from f6b7649 to fe3c7e5 Compare February 28, 2023 22:48
@kaushalkapasi kaushalkapasi marked this pull request as ready for review February 28, 2023 22:48
@kaushalkapasi kaushalkapasi requested a review from a team February 28, 2023 22:48
kaushalkapasi and others added 10 commits March 1, 2023 13:16
@kaushalkapasi
fix gradle build & release on gradle 7.5.1
5ddc87c
@kaushalkapasi
adds Close method for local client to gracefully shutdown Config and …
4c20a8a 
…Event Managers
@kaushalkapasi
add check to Local Client initialize method to ensure DVC Server key …
18cd37e 
…is provided and the correct format
@kaushalkapasi
Variable model always returns type and defaultValue fields. remove un…
52465ee 
…used reasonUsingDefault. update type enum from value to use fromClass
@kaushalkapasi
add event type checking for track method in Local and Cloud clients. …
f0814f8 
…Cloud client return is now a void method that will not return on success
@chantalchung @kaushalkapasi
ignore unknown properties on DVCResponse (#49)
0809bc6
@kaushalkapasi
add event type checking for track method in Local and Cloud clients. …
30a052a 
…Cloud client return is now a void method that will not return on success
@kaushalkapasi
[fix] fix signing task for publishing to maven
b4e7c4d
@kaushalkapasi
[chore] add unit test GH Action to be required for PR merging to main
326bcea
@kaushalkapasi
[fix] DVC-6323: split Variable and BaseVariable classes to serve diff…
f54ab47 
…erent usecases. BaseVariable is used for allVariables while Variable is used for variable calls
@kaushalkapasi kaushalkapasi merged commit d87ff6d into main Mar 1, 2023
@kaushalkapasi kaushalkapasi deleted the test-harness-fixes branch March 1, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suthar26 suthar26 suthar26 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaushalkapasi @suthar26 @chantalchung