-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: removed unused keyword #179
Conversation
@matthias-Q I'm requesting another review, I added some more commits that ensure our You can see the failure message here: https://github.com/DerekStride/tree-sitter-sql/actions/runs/5456777435/jobs/9930044879 And see it fixed in the latest commit. |
I am bit short on time today. I can take a look tomorrow. I was noticing a lot of "new" keywords in the highlights. Did we missed all of them? Do we need to add them to nvim-treesitter as well? If so, I would maybe put some of them not under the |
61f6e9b
to
f1bdfdf
Compare
f1bdfdf
to
27fd9fd
Compare
yeah they were all missing & need to be synced to nvim-treesitter.
I moved a few of them to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I made two suggestions for the highlights, but in the end I expect the maintainers of nvim-treesitter to have their own opinion 😄
@@ -9,7 +9,6 @@ | |||
(keyword_spgist) | |||
(keyword_gin) | |||
(keyword_brin) | |||
(keyword_float) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
float
can be a @function.call
and a @type.builtin
select
1::float;
select
float(1);
So I would keep it there. in nvim-treesitter - the last match wins, thus the order matters here (which makes things unnecessarily complicated imo.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have float
in @type.builtin
and the rule for invocation
should cover the @function.call
case.
(keyword_analyze) | ||
(keyword_rewrite) | ||
(keyword_statistics) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think statistics
and stats
should be @type.qualifier
and not @keyword
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed these from here because they were duplicated in @type.qualifier
already 👍
What
fixes #155
Use the
keyword_language
node in the grammar rules.