Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyword_language is unused, renderet to parser.c as aux_sym_* #155

Closed
LeoniePhiline opened this issue Jun 19, 2023 · 1 comment · Fixed by #179
Closed

keyword_language is unused, renderet to parser.c as aux_sym_* #155

LeoniePhiline opened this issue Jun 19, 2023 · 1 comment · Fixed by #179

Comments

@LeoniePhiline
Copy link
Contributor

While preparing helix-editor/helix#7387 I noticed that a (keyword_language) query makes tree-sitter fail parsing with a NodeType error.

Upon investigation, I found that:

The symbol is defined in grammar.json.

But it is not defined in node-types.json.

In parser.c, it is defined as aux_sym_keyword_language_token1. 🤔 (see also the codegen)

(keyword_language) appears to be unused.

I think it can be removed - or shall it be used for function_language?

@DerekStride
Copy link
Owner

I changed function_language to reference the keyword the query should work as expected on the latest version of the parser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants