Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Flyway with testcontainers init script #585

Merged
merged 1 commit into from
May 29, 2023
Merged

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented May 27, 2023

As of Quarkus 2.16.3 it is possible to provide an init script to the database testcontainer (quarkusio/quarkus#30455).

We previously had to use Flyway to initialize the container with the API server SQL schema. This is no longer necessary.

As of Quarkus 2.16.3 it is possible to provide an init script to the database testcontainer (quarkusio/quarkus#30455).

We previously had to use Flyway to initialize the container with the API server SQL schema. This is no longer necessary.

Signed-off-by: nscuro <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Collaborator

@sahibamittal sahibamittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sahibamittal sahibamittal merged commit d209dd2 into main May 29, 2023
@sahibamittal sahibamittal deleted the remove-flyway branch May 29, 2023 09:39
sahibamittal added a commit that referenced this pull request May 29, 2023
commit 1d6c7f1
Author: Niklas <[email protected]>
Date:   Mon May 29 11:42:01 2023 +0200

    Revise labels in Helm chart (#583)

    * Properly truncate `name` and `fullname` such that they never exceed 63 characters, even with suffixes
    * Add `app.kubernetes.io/part-of` label
    * Make `app.kubernetes.io/name` specific to individual services, instead of using a common label values across all services
    * Use fully qualified names in `metadata.name`

    Signed-off-by: nscuro <[email protected]>

commit 4f3f6fe
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon May 29 10:40:29 2023 +0100

    Bump checkstyle from 10.11.0 to 10.12.0 (#587)

commit d209dd2
Author: Niklas <[email protected]>
Date:   Mon May 29 11:39:32 2023 +0200

    Replace Flyway with testcontainers init script (#585)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants