Revise labels in Helm chart #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Properly truncate `name` and `fullname` such that they never exceed 63 characters, even with suffixes * Add `app.kubernetes.io/part-of` label * Make `app.kubernetes.io/name` specific to individual services, instead of using a common label values across all services * Use fully qualified names in `metadata.name` Signed-off-by: nscuro <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
sahibamittal
added a commit
that referenced
this pull request
May 29, 2023
commit 1d6c7f1 Author: Niklas <[email protected]> Date: Mon May 29 11:42:01 2023 +0200 Revise labels in Helm chart (#583) * Properly truncate `name` and `fullname` such that they never exceed 63 characters, even with suffixes * Add `app.kubernetes.io/part-of` label * Make `app.kubernetes.io/name` specific to individual services, instead of using a common label values across all services * Use fully qualified names in `metadata.name` Signed-off-by: nscuro <[email protected]> commit 4f3f6fe Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon May 29 10:40:29 2023 +0100 Bump checkstyle from 10.11.0 to 10.12.0 (#587) commit d209dd2 Author: Niklas <[email protected]> Date: Mon May 29 11:39:32 2023 +0200 Replace Flyway with testcontainers init script (#585)
nscuro
added a commit
that referenced
this pull request
May 30, 2023
I missed to move some resources from `*SelectorLabels` to `*Labels` for `metadata.labels` fields in #583, leading to inconsistencies in labels across resources. Signed-off-by: nscuro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nameandfullnamesuch that they never exceed 63 characters, even with suffixesapp.kubernetes.io/part-oflabelapp.kubernetes.io/namespecific to individual services, instead of using a common label values across all servicesmetadata.name