Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement VulnerabilityPolicyEvaluator #937

Closed
nscuro opened this issue Nov 28, 2023 · 1 comment
Closed

Implement VulnerabilityPolicyEvaluator #937

nscuro opened this issue Nov 28, 2023 · 1 comment
Labels
component/api-server domain/vuln-policy enhancement New feature or request p2 Non-critical bugs, and features that help organizations to identify and reduce risk size/M Medium effort

Comments

@nscuro
Copy link
Member

nscuro commented Nov 28, 2023

Extracted from #930 (comment)

  • Either as new class, or integrate into existing CelPolicyEngine
  • Can develop against a VulnerabilityPolicyProvider interface at first, which can easily be mocked
  • Same as CelPolicyEngine, it will potentially need to load additional data from DB based on condition expression requirements
  • Think about where caching may be used to avoid redundant expensive evaluation
@nscuro nscuro added enhancement New feature or request p2 Non-critical bugs, and features that help organizations to identify and reduce risk size/M Medium effort component/api-server labels Nov 28, 2023
@nscuro nscuro mentioned this issue Nov 28, 2023
Open
@nscuro nscuro self-assigned this Nov 28, 2023
@nscuro nscuro changed the title Implement VulnerabilityPolicyEvaluator Implement VulnerabilityPolicyEvaluator Nov 30, 2023
This was referenced Nov 30, 2023
Closed
Merged
Merged
nscuro added a commit to DependencyTrack/hyades-apiserver that referenced this issue Dec 6, 2023
@nscuro
Construct NEW_VULNERABILITY and NEW_VULNERABLE_DEPENDENCY notific…
7c1dd69 
…ation subjects with JDBI

This is a prerequisite for DependencyTrack/hyades#937 in order to make notification dispatching less resource-intensive.

Loading this data via ORM is cumbersome, as we either load too much (due to default fetch groups), or too less (due to lazy loading). Getting the subjects in a single query also reduces database round trips.

Signed-off-by: nscuro <[email protected]>
@nscuro nscuro mentioned this issue Dec 6, 2023
Merged
2 tasks
nscuro added a commit to DependencyTrack/hyades-apiserver that referenced this issue Dec 6, 2023
@nscuro
Construct NEW_VULNERABILITY and NEW_VULNERABLE_DEPENDENCY notific…
7d2eb56 
…ation subjects with JDBI

This is a prerequisite for DependencyTrack/hyades#937 in order to make notification dispatching less resource-intensive.

Loading this data via ORM is cumbersome, as we either load too much (due to default fetch groups), or too less (due to lazy loading). Getting the subjects in a single query also reduces database round trips.

Signed-off-by: nscuro <[email protected]>
nscuro added a commit to DependencyTrack/hyades-apiserver that referenced this issue Dec 6, 2023
@nscuro
Construct NEW_VULNERABILITY and NEW_VULNERABLE_DEPENDENCY notific…
c662579 
…ation subjects with JDBI

This is a prerequisite for DependencyTrack/hyades#937 in order to make notification dispatching less resource-intensive.

Loading this data via ORM is cumbersome, as we either load too much (due to default fetch groups), or too less (due to lazy loading). Getting the subjects in a single query also reduces database round trips.

Signed-off-by: nscuro <[email protected]>
nscuro added a commit to DependencyTrack/hyades-apiserver that referenced this issue Dec 6, 2023
@nscuro
Construct NEW_VULNERABILITY and NEW_VULNERABLE_DEPENDENCY notific…
1a85436 
…ation subjects with JDBI

This is a prerequisite for DependencyTrack/hyades#937 in order to make notification dispatching less resource-intensive.

Loading this data via ORM is cumbersome, as we either load too much (due to default fetch groups), or too less (due to lazy loading). Getting the subjects in a single query also reduces database round trips.

Signed-off-by: nscuro <[email protected]>
nscuro added a commit to DependencyTrack/hyades-apiserver that referenced this issue Dec 7, 2023
@nscuro
Construct NEW_VULNERABILITY and NEW_VULNERABLE_DEPENDENCY notific…
fc03b5f 
…ation subjects with JDBI

This is a prerequisite for DependencyTrack/hyades#937 in order to make notification dispatching less resource-intensive.

Loading this data via ORM is cumbersome, as we either load too much (due to default fetch groups), or too less (due to lazy loading). Getting the subjects in a single query also reduces database round trips.

Signed-off-by: nscuro <[email protected]>
nscuro added a commit to DependencyTrack/hyades-apiserver that referenced this issue Dec 7, 2023
@nscuro
Construct NEW_VULNERABILITY and NEW_VULNERABLE_DEPENDENCY notific…
2f1bb86 
…ation subjects with JDBI

This is a prerequisite for DependencyTrack/hyades#937 in order to make notification dispatching less resource-intensive.

Loading this data via ORM is cumbersome, as we either load too much (due to default fetch groups), or too less (due to lazy loading). Getting the subjects in a single query also reduces database round trips.

Signed-off-by: nscuro <[email protected]>
@nscuro
Copy link
Member Author

nscuro commented Dec 14, 2023

Implemented in #464 and #465.

@nscuro nscuro closed this as completed Dec 14, 2023
@nscuro nscuro removed their assignment Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/api-server domain/vuln-policy enhancement New feature or request p2 Non-critical bugs, and features that help organizations to identify and reduce risk size/M Medium effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Implement VulnerabilityPolicyEvaluator DependencyTrack/hyades-apiserver
1 participant
@nscuro