Construct NEW_VULNERABILITY and NEW_VULNERABLE_DEPENDENCY notification subjects with JDBI
#471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nscuro
force-pushed
the
jdbi-notifications
branch
from
7c1dd69 to
7d2eb56
Compare
3 tasks
nscuro
force-pushed
the
jdbi-notifications
branch
2 times, most recently
from
c662579 to
1a85436
Compare
…ation subjects with JDBI This is a prerequisite for DependencyTrack/hyades#937 in order to make notification dispatching less resource-intensive. Loading this data via ORM is cumbersome, as we either load too much (due to default fetch groups), or too less (due to lazy loading). Getting the subjects in a single query also reduces database round trips. Signed-off-by: nscuro <[email protected]>
nscuro
force-pushed
the
jdbi-notifications
branch
from
1a85436 to
fc03b5f
Compare
VithikaS
approved these changes
Dec 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a prerequisite for DependencyTrack/hyades#937 in order to make notification dispatching less resource-intensive.
Loading this data via ORM is cumbersome, as we either load too much (due to default fetch groups), or too less (due to lazy loading). Getting the subjects in a single query also reduces database round trips.
Addressed Issue
Relates to DependencyTrack/hyades#937
Additional Details
N/A
Checklist
This PR fixes a defect, and I have provided tests to verify that the fix is effectiveThis PR introduces changes to the database model, and I have added corresponding update logicThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly