Fix redundant notifications for existing policy violations #2656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes DependencyTrack#2655 Signed-off-by: nscuro <[email protected]>
|
Just thinking out loud: In #2523 there can be, in theory, two parallel policy evaluation events taking place. Could/Should there be some transactional behaviour here to avoid duplicate notifications in that (corner?) case? |
|
@valentijnscholten That is a very good point that I was thinking of a lot recently, too. Problem is that dispatching of events is not transactional, so really what we'd need is an implementation of the outbox pattern. |
|
I have raised an issue for transactional notifications here: #2674 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a defect where
POLICY_VIOLATIONnotifications were sent not only for newly identified violations, but also for already existing ones.Addressed Issue
Fixes #2655
Additional Details
N/A
Checklist
This PR implements an enhancement, and I have provided tests to verify that it works as intendedThis PR introduces changes to the database model, and I have added corresponding update logicThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly