Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate policy evaluation into its own task #2523

Merged
merged 4 commits into from
Jun 28, 2023
Merged

Separate policy evaluation into its own task #2523

merged 4 commits into from
Jun 28, 2023

Conversation

walterdeboer
Copy link

@walterdeboer walterdeboer commented Feb 24, 2023 •
edited
Loading

Description

Separate policy evaluation into its own task

Addressed Issue

closes #2423

Additional Details

I've chained the VulnerabilityAnalysisEvent and the RepositoryMetaEvent as both are needed for example when evaluating an VersionDistancePolicyEvaluator (#2528 )

N.B. no new tests added. I assume it's covered in excisting tests as there is no logical change? Will check on this...

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@walterdeboer walterdeboer force-pushed the feature/2423 branch 2 times, most recently from 6e25283 to 287d042 Compare March 11, 2023 23:09
@nscuro nscuro added this to the 4.9 milestone Apr 10, 2023
@valentijnscholten valentijnscholten mentioned this pull request Apr 11, 2023
Merged
2 tasks
@walterdeboer walterdeboer force-pushed the feature/2423 branch 7 times, most recently from 735f14a to 1897740 Compare April 28, 2023 07:27
@nscuro
Copy link
Member

nscuro commented Jun 26, 2023

@walterdeboer I only now realized that the new event is not registered in EventSubsystemInitializer yet. It needs to be EVENT_SERVICE.subscribed to and EVENT_SERVICE.unsubscribed from. Currently the new events are dispatched, but no task is registered to handle them.

@walterdeboer walterdeboer marked this pull request as draft June 27, 2023 18:09
@walterdeboer walterdeboer marked this pull request as ready for review June 27, 2023 19:04
@walterdeboer walterdeboer requested a review from nscuro June 27, 2023 19:36
nscuro
nscuro approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @walterdeboer!

@nscuro nscuro merged commit 9873f88 into DependencyTrack:master Jun 28, 2023
@nscuro nscuro removed this from the 4.9 milestone Jun 28, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sonatype-lift sonatype-lift[bot] sonatype-lift[bot] left review comments

@nscuro nscuro nscuro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate policy evaluation into its own task
3 participants
@walterdeboer @nscuro @heubeck