Code

136 persist winners for irv contests#101

Code

Merged

vteague merged 27 commits intomainDemocracyDevelopers/raire-service:mainfrom 136-persist-winners-for-irv-contestsDemocracyDevelopers/raire-service:136-persist-winners-for-irv-contestsCopy head branch name to clipboardJul 22, 2024

+1,666-431

Commits

Commits on Jul 12, 2024

• Added GenerateAssertionsResponseOrError class.

  vteague

  committed
  d38be11

• Refactored assertion-persisting to incorporate persisting in the case of failure to generate assertions.

  vteague

  committed
  0b0ccfe

Commits on Jul 13, 2024

• Getting proper errors out of raire response.

  vteague

  committed
  09544ab

• Getting proper errors out of raire response.

  vteague

  committed
  30d7ac5

• Now saving both correct and error responses for GenerateAssertionsSummary.

  vteague

  committed
  264024d

• Now saving both correct and error responses for GenerateAssertionsSummary.

  vteague

  committed
  2883f20

• Now saving both correct and error responses for GenerateAssertionsSummary.

  vteague

  committed
  7d7c6c5

• Generate Assertions Summary done; all existing tests passing.

  vteague

  committed
  9614aa2

• Added summary to known tests.

  vteague

  committed
  cccdeba

• Added summary to NSW tests and wicked tests.

  vteague

  committed
  5214448

• Added a test for summary when trimming assertions times out.

  vteague

  committed
  0a95289

Commits on Jul 15, 2024

• Added a test for summary when trimming assertions times out.

  vteague

  committed
  06e2a65

• Correcting tests to use the recorded winner rather than the winner from the request.

  vteague

  committed
  37467b6

• Existing tests all pass.

  vteague

  committed
  79f4cdf

• Tests for proper retrieval of error generate assertions summaries.

  vteague

  committed
  416a899

Commits on Jul 18, 2024

• Parameterized tests for generation summary storage in the case of errors.

  vteague

  committed
  14edb77

• Complete tests for persisting errors and warnings as GenerateAssertionsSummary.

  vteague

  committed
  2f477ba

• Added tests that invalid solutions were not persisted.

  vteague

  committed
  1ba49a5

• Test replacement of results in successive saves for the same contest.

  vteague

  committed
  ca3ff09

• Store blank winner in database if unknown - use "UNKNOWN_WINNER" only for user-facing reporting.

  vteague

  committed
  aaa7550

• Update existing tests for more expressive errors.

  vteague

  committed
  a98e68b

• Check that bad request errors do not persist a GenerateAssertionSummary failure record.

  vteague

  committed
  c64afb7

• Tests for wrong candidate names in request.

  vteague

  committed
  4fafd4f

Commits on Jul 19, 2024

• Complete tests for generate assertions summaries, including testing graceful failure if the database state is not what we expect.

  vteague

  committed
  34920ca

• Fixed failing test.

  vteague

  committed
  441754c

• Improved comments in failure example summaries.

  vteague

  committed
  c2cea7a

• Improvements from @michelleblom's review.

  vteague

  committed
  7b8ca7d