136 persist winners for irv contests #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of failure to generate assertions.
… for user-facing reporting.
…ry failure record.
…raceful failure if the database state is not what we expect.
michelleblom
approved these changes
Jul 19, 2024
| @@ -99,12 +99,13 @@ public ResponseEntity<GenerateAssertionsResponse> serve(@RequestBody GenerateAss | |||
| logger.debug(String.format("%s Calling raire-java with assertion generation request.",prefix)); | |||
| RaireResultOrError solution = generateAssertionsService.generateAssertions(request); | |||
|
|
|||
There was a problem hiding this comment.
If the persisting is done on line 102, then I think we need to change the comment on 105 as we have already saved them to the database.
| @Column(name = "contest_name", unique = true, updatable = false, nullable = false) | ||
| private String contestName = ""; | ||
|
|
||
| /** |
There was a problem hiding this comment.
Do we mean to make the following attributes public given there are methods for updating them?
There was a problem hiding this comment.
They have to be read by the getAssertions services - it's really another example of where 'public final' is the right thing, but I don't think final is compatible with the database. You're right, though, they shouldn't be publicly writeable - I've now changed them to private with getters.
| /** | ||
| * Retrieve the GenerateAssertionsSummary record for this contest, and either return the winner's | ||
| * index in the candidate list (if it is present and valid) or throw an error with the appropriate | ||
| * error message (if either there is no record, or the record contains an error rather than a winner). |
There was a problem hiding this comment.
Typo: GenerateAssetionsSummary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new database table for storing the assertion generation summary - basically a winner (if it succeeded) and an error message (if it failed). The database table is stored, and then used subsequently when generating reports.
As a nice bonus, this allows us to remove the winner from the get assertions request.