Issue #1313 recharge from imod5 cap data #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c520599.
JoerivanEngelen
requested review from
Manangka and
HendrikKok
and removed request for
Manangka
JoerivanEngelen
changed the base branch from
master
to
issue_#1260_from_imod5_data_metaswap
|
Manangka
requested changes
Dec 2, 2024
| @@ -330,6 +330,9 @@ def from_imod5_data( | |||
| wel_key, imod5_data, times | |||
| ) | |||
|
|
|||
| if "cap" in imod5_keys: | |||
| result["msw-rch"] = Recharge.from_imod5_cap_data(imod5_data) # type: ignore | |||
There was a problem hiding this comment.
I would reconsider the place you put you converter code. The Recharge package now needs to now about the imod5 model. What would happen if we add another converter e.g. flopy? Then mf6 module also needs to know about that.
I would recommend moving all the converter code to a separate module. And in that module the code then knows about the imod5 data/packages and the mf6 data/packages
There was a problem hiding this comment.
I agree, but it would be too large of a task to fix in this PR. I created a separate issue for this: #1319
Manangka
approved these changes
Dec 3, 2024
JoerivanEngelen
merged commit 8461d63
into
issue_#1260_from_imod5_data_metaswap
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1313
Description
Construct an rch-package from iMOD5 data in the CAP package, loaded with the
open_projectfile_datafunction. Package isused to couple MODFLOW6 to MetaSWAP models. Active cells will have a recharge rate of 0.0.
At the moment, MetaSWAP can only be coupled to the first layer, as this is also the case for
primod. iMOD Coupler these days supports coupling to other layers as well, butprimoddoesn't. Picking this up for iMOD Python andprimodis worthy a separate story.In detail:
Recharge.from_imod5_cap_dataclass method, to construct an empty Recharge package with 0.0 rate.GridDatahelper functions tomsw/utilities/imod5_converter.py, so that they can be reused.Checklist
Issue #nr, e.g.Issue #737