Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add imod.mf6.Recharge.from_imod5_cap_data #1313

Closed
Tracked by #1260
JoerivanEngelen opened this issue Nov 29, 2024 · 0 comments · Fixed by #1315
Closed
Tracked by #1260

Add imod.mf6.Recharge.from_imod5_cap_data #1313

JoerivanEngelen opened this issue Nov 29, 2024 · 0 comments · Fixed by #1315
Assignees
@JoerivanEngelen
Milestone
v1.0 beta: Backwa...

Comments

@JoerivanEngelen
Copy link
Contributor

JoerivanEngelen commented Nov 29, 2024 •
edited
Loading

Requirements

  • Recharge cells where msw cells are active, with rate 0.0.
  • Classmethod should be named from_imod5_cap_data, consistent method added to LayeredWell
@JoerivanEngelen JoerivanEngelen mentioned this issue Nov 29, 2024
Closed
9 tasks
@github-project-automation github-project-automation bot moved this to 📯 New in iMOD Suite Nov 29, 2024
@JoerivanEngelen JoerivanEngelen changed the title Initiate empty Modflow6 Recharge package Add imod.mf6.Recharge.from_imod5_cap_data Nov 29, 2024
@JoerivanEngelen JoerivanEngelen self-assigned this Nov 29, 2024
@JoerivanEngelen JoerivanEngelen moved this from 📯 New to 📝Refined in iMOD Suite Nov 29, 2024
@JoerivanEngelen JoerivanEngelen moved this from 📝Refined to 🏗 In Progress in iMOD Suite Nov 29, 2024
@JoerivanEngelen JoerivanEngelen mentioned this issue Dec 2, 2024
Merged
5 tasks
JoerivanEngelen added a commit that referenced this issue Dec 3, 2024
@JoerivanEngelen
Issue #1313 recharge from imod5 cap data (#1315)
8461d63 
Fixes #1313

# Description
Construct an rch-package from iMOD5 data in the CAP package, loaded with
the ``open_projectfile_data`` function. Package is
used to couple MODFLOW6 to MetaSWAP models. Active cells will have a
recharge rate of 0.0.

At the moment, MetaSWAP can only be coupled to the first layer, as this
is also the case for ``primod``. iMOD Coupler these days supports
coupling to other layers as well, but ``primod`` doesn't. Picking this
up for iMOD Python and ``primod`` is worthy a separate story.

In detail:
- Add ``Recharge.from_imod5_cap_data`` class method, to construct an
empty Recharge package with 0.0 rate.
- Minor refactor: Put ``GridData`` helper functions to
``msw/utilities/imod5_converter.py``, so that they can be reused.

# Checklist

- [x] Links to correct issue
- [x] Update changelog, if changes affect users
- [x] PR title starts with ``Issue #nr``, e.g. ``Issue #737``
- [x] Unit tests were added
- [ ] **If feature added**: Added/extended example
@JoerivanEngelen JoerivanEngelen moved this from 🏗 In Progress to 🧐 In Review in iMOD Suite Dec 3, 2024
@github-project-automation github-project-automation bot moved this from 🧐 In Review to ✅ Done in iMOD Suite Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoerivanEngelen JoerivanEngelen

Labels
None yet
Projects
iMOD Suite
Status: ✅ Done
Milestone
v1.0 beta: Backwards Compatibility iM...
Development

Successfully merging a pull request may close this issue.

Issue #1313 recharge from imod5 cap data Deltares/imod-python
1 participant
@JoerivanEngelen