Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add control tests #300

Closed
SouthEndMusic opened this issue Jun 12, 2023 · 1 comment · Fixed by #384
Closed

Add control tests #300

SouthEndMusic opened this issue Jun 12, 2023 · 1 comment · Fixed by #384
Assignees
@SouthEndMusic
Labels
control Rule based control of physical layer
Milestone
1. basic hydro fu...

Comments

@SouthEndMusic
Copy link
Collaborator

SouthEndMusic commented Jun 12, 2023 •
edited by SnippenE
Loading

Add tests for control behavior based on control output file (#299).

What should be tested?

See #262 for multiple testcases
@SouthEndMusic SouthEndMusic added control Rule based control of physical layer needs-refinement Issues that are too large and need refinement labels Jun 12, 2023
@github-project-automation github-project-automation bot moved this to To do in Ribasim Jun 12, 2023
@gijsber
Copy link
Contributor

gijsber commented Jun 12, 2023

  • does the control_state change at the right moment in time ?
  • has the proper control_action been taken which is associated with this control state

@SnippenE SnippenE mentioned this issue Jun 20, 2023
Closed
5 tasks
@SnippenE SnippenE removed the needs-refinement Issues that are too large and need refinement label Jun 20, 2023
@evetion evetion moved this from To do to Sprint backlog in Ribasim Jun 22, 2023
@visr visr assigned SouthEndMusic and unassigned visr Jul 3, 2023
@SouthEndMusic SouthEndMusic mentioned this issue Jul 3, 2023
Merged
@visr visr closed this as completed in #384 Jul 4, 2023
visr added a commit that referenced this issue Jul 4, 2023
@SouthEndMusic @visr
Add tests for discrete control times (#384)
ed4fbef 
Fixes #300.

---------

Co-authored-by: Bart de Koning <[email protected]>
Co-authored-by: Martijn Visser <[email protected]>
@github-project-automation github-project-automation bot moved this from Sprint backlog to ✅ Done in Ribasim Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SouthEndMusic SouthEndMusic

Labels
control Rule based control of physical layer
Projects
Ribasim
Archived in project
Milestone
1. basic hydro functionality (physica...
Development

Successfully merging a pull request may close this issue.

Add tests for discrete control times Deltares/Ribasim
4 participants
@visr @gijsber @SouthEndMusic @SnippenE