Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testmodels to represent automatic weir behaviour which fluctuates Q to keep H at a predefined level #262

Closed
5 tasks done
gijsber opened this issue Jun 1, 2023 · 8 comments
Assignees
Labels
control Rule based control of physical layer

Comments

@gijsber
Copy link
Contributor

gijsber commented Jun 1, 2023

We need functionality to represent a very common situation in NL where an automatic were adjusts Q to keep H at a predefined level.

Preferably it is defined in an easy to use way, e.g. a specific type of connector node with some embedded control or a specific type of control node

Refinement 16/6/2023 Bart, Martijn, Peter

@gijsber gijsber added this to Ribasim Jun 1, 2023
@gijsber gijsber converted this from a draft issue Jun 1, 2023
@gijsber gijsber added the control Rule based control of physical layer label Jun 1, 2023
@Hofer-Julian Hofer-Julian changed the title LevelControl to represent automatic weir behaviour which fluctuates Q to keep H at a predefined level LevelControl to represent automatic weir behaviour which fluctuates $Q$ to keep $H$ at a predefined level Jun 1, 2023
@Hofer-Julian Hofer-Julian changed the title LevelControl to represent automatic weir behaviour which fluctuates $Q$ to keep $H$ at a predefined level LevelControl to represent automatic weir behaviour which fluctuates Q to keep H at a predefined level Jun 1, 2023
@SnippenE SnippenE moved this from To do to Sprint backlog in Ribasim Jun 8, 2023
@SnippenE SnippenE added the needs-refinement Issues that are too large and need refinement label Jun 8, 2023
@gijsber
Copy link
Contributor Author

gijsber commented Jun 8, 2023

Use case A.1: free flow situation with abundant upstream inflow and level control on the upstream basin
a fluctuating timeseries at a FlowBoundary, followed by 2 basins with a automatic weir inbetween. The weir has a target_waterlevel for the upstream basin as setpoint (could be static or dynamic) and a minimum and maximum waterlevel within which it should stay.
The outflow of the upstream basin needs to be adjusted to achieve the setpoint

@gijsber
Copy link
Contributor Author

gijsber commented Jun 8, 2023

Use case A.2: free flow situation with abundant upstream volume and level control on the downstream basin
a fluctuating timeseries at a FlowBoundary, followed by 2 basins with an automatic weir inbetween. The weir has a target_waterlevel for the downstream basin as setpoint and a minimum and maximum waterlevel within which it should stay. the downstream basin has a huge loss (evaporation or seepage) which needs to be compensated by inflow from the upstream basin.
The inflow to the downstream basin is the controlled variable.

@gijsber
Copy link
Contributor Author

gijsber commented Jun 8, 2023

Use case D.1: free flow situation with limited upstream inflow and level control on both the upstream and the downstream basin
a fluctuating timeseries at a FlowBoundary, followed by 2 basins with an automatic weir inbetween. The weir has a target_waterlevel for the downstream basin as setpoint and a minimum and maximum waterlevel within which it should stay. The downstream basin has a huge loss (evaporation or seepage) which needs to be compensated by inflow from the upstream basin. The weir has a target_waterlevel for the upstream basin as setpoint and a minimum and maximum waterlevel within which it should stay.
Keeping the minimum water level at the upstream basin has priority over keeping the minimum water level at the downstream basin.
The inflow to the downstream basin is the controlled variable.

@gijsber
Copy link
Contributor Author

gijsber commented Jun 8, 2023

Use case B.1: dual basin situation without inflow with a pump to control the water level of the upstream basin
The upstream basin has no upstream inflow, but has a target_waterlevel and a min/max water level, as well as an evaporation and infiltration loss that needs to be compensated. The water comes from the (huge) downstream basin storage and is brought upstream by a pump.

@gijsber
Copy link
Contributor Author

gijsber commented Jun 8, 2023

Use case C.1 dual basin with limited inflow and a pump and an automatic weir to control the water level of the upstream basin.
the upstream basin has a target_waterlevel and a min/max water level, as well as an evaporation and infiltration loss.
In wintertime, the upstream inflow is sufficient to compensate the evaporation and infiltration loss, while the remaining water is discharged as a free flow sitation over the (automatic) weir to the downstream basin.
In summertime, the upstream inflow is minimal and insufficient to compensate for the evaporation and infiltration loss. To preserve the minimal water level, the pump needs to be activated to bring water from the downstream basin to the upstream basin.

@gijsber gijsber removed their assignment Jun 8, 2023
@gijsber gijsber removed the needs-refinement Issues that are too large and need refinement label Jun 8, 2023
@gijsber gijsber added the needs-refinement Issues that are too large and need refinement label Jun 12, 2023
@SnippenE SnippenE added needs-refinement Issues that are too large and need refinement and removed needs-refinement Issues that are too large and need refinement labels Jun 15, 2023
@gijsber
Copy link
Contributor Author

gijsber commented Jun 15, 2023

Refinement 16/6/2023 Bart, Martijn, Peter

@SnippenE SnippenE added epic and removed needs-refinement Issues that are too large and need refinement labels Jun 20, 2023
@gijsber gijsber assigned gijsber and SouthEndMusic and unassigned gijsber Jul 20, 2023
@gijsber gijsber changed the title LevelControl to represent automatic weir behaviour which fluctuates Q to keep H at a predefined level Testmodels to represent automatic weir behaviour which fluctuates Q to keep H at a predefined level Jul 20, 2023
@SouthEndMusic SouthEndMusic moved this from Sprint backlog to 🏗 In progress in Ribasim Aug 8, 2023
@SouthEndMusic
Copy link
Collaborator

Use case A.1

This seems to be covered by the pump, as outflow from the controlled basin is required here.

@SouthEndMusic SouthEndMusic moved this from 🏗 In progress to Sprint backlog in Ribasim Aug 8, 2023
@SouthEndMusic
Copy link
Collaborator

SouthEndMusic commented Aug 10, 2023

Regarding all these test models:

@gijsber gijsber moved this from Sprint backlog to To do in Ribasim Aug 17, 2023
@gijsber gijsber self-assigned this Aug 17, 2023
@gijsber gijsber moved this from To do to Sprint backlog in Ribasim Aug 31, 2023
@gijsber gijsber moved this from Sprint backlog to To do in Ribasim Sep 14, 2023
@github-project-automation github-project-automation bot moved this from To do to ✅ Done in Ribasim Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
control Rule based control of physical layer
Projects
Archived in project
Development

No branches or pull requests

3 participants