Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time dependent subgrid #1010

Closed
harm-nomden-sweco opened this issue Jan 30, 2024 · 1 comment · Fixed by #1975
Closed

Time dependent subgrid #1010

harm-nomden-sweco opened this issue Jan 30, 2024 · 1 comment · Fixed by #1975
Labels
needs-refinement Issues that are too large and need refinement physics Physical process representation

Comments

@harm-nomden-sweco
Copy link

harm-nomden-sweco commented Jan 30, 2024 •
edited by visr
Loading

What
As a user I would like to have a time-dependent subgrid and profile.

Why
The backwatercurves can be different for example for winter/summer (due to roughness)
@github-project-automation github-project-automation bot moved this to To do in Ribasim Jan 30, 2024
@harm-nomden-sweco harm-nomden-sweco changed the title time-dependent subgrid time-dependent subgrid and profile Jan 30, 2024
@SnippenE SnippenE added enhancement physics Physical process representation needs-refinement Issues that are too large and need refinement labels Jan 31, 2024
@visr visr changed the title time-dependent subgrid and profile Time dependent subgrid and profile Mar 14, 2024
@visr
Copy link
Member

visr commented Mar 14, 2024

Related to #208

@SnippenE SnippenE moved this from To do to Paused in Ribasim Apr 22, 2024
@visr visr changed the title Time dependent subgrid and profile Time dependent subgrid Sep 3, 2024
@visr visr removed the Marker label Sep 30, 2024
@visr visr removed the enhancement label Nov 26, 2024
@visr visr mentioned this issue Dec 13, 2024
Merged
visr added a commit that referenced this issue Dec 20, 2024
@visr @evetion
Add Basin / subgrid_time table (#1975)
aecf57f 
Fixes #1010

This adds `Basin / subgrid_time`. So far the only relation we could
update over time was `Q(h)` (`TabulatedRatingCurve / time`), and that is
implemented differently. I wrote #1976 to get those more in line. It's
good to read that since it explains the implementation here.

Things I dislike:
- Need a special case to allow an underscore in `Basin / subgrid_time`,
just like `Basin / concentration_`.
- Other dynamic tables are just named time and have a static counterpart
like `Basin / static`, `Basin / time`. Since we already have `Basin /
subgrid` we cannot do that.

---------

Co-authored-by: Maarten Pronk <[email protected]>
@github-project-automation github-project-automation bot moved this from Paused to ✅ Done in Ribasim Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-refinement Issues that are too large and need refinement physics Physical process representation
Projects
Ribasim
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Basin / subgrid_time table Deltares/Ribasim
3 participants
@visr @SnippenE @harm-nomden-sweco