Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support time dependent parameters for pump and outlet types #208

Open
6 tasks
visr opened this issue May 12, 2023 · 4 comments
Open
6 tasks

Support time dependent parameters for pump and outlet types #208

visr opened this issue May 12, 2023 · 4 comments
Labels
physics Physical process representation

Comments

@visr
Copy link
Member

visr commented May 12, 2023

Currently only Basin and TabulatedRatingCurve support it.

What is needed:

If #178 would be merged first these steps might change a little.

For Basin the time-dependent table is called Basin / forcing, but I'd propose " / time" for all these tables.
The TabulatedRatingCurve is unique in that a table has to be updated rather than scalars. For the other node types it will probably look more similar to the basin_update. I guess perhaps it is possible to automate parts of this, but that could also be done after implementing it manually first. Right now it's a limitation that only some things can get updated.

EDIT 2024-01: @Fati-Mon needs Pump / time and Outlet / time.

@github-project-automation github-project-automation bot moved this to 🔲 Todo in Ribasim May 12, 2023
@Hofer-Julian Hofer-Julian changed the title support time dependent parameters for all node types Support time dependent parameters for all node types May 15, 2023
@SnippenE SnippenE added QGIS Ribasim QGIS plugin physics Physical process representation needs-refinement Issues that are too large and need refinement and removed QGIS Ribasim QGIS plugin labels Jun 19, 2023
@visr visr removed the needs-refinement Issues that are too large and need refinement label Jun 26, 2023
@evetion
Copy link
Member

evetion commented Jun 26, 2023

I guess perhaps it is possible to automate parts of this, but that could also be done after implementing it manually first.

Refinement: let's check the duplication and automate/generalize after the first manual implementation(s).

@SouthEndMusic
Copy link
Collaborator

Sub issues:

#397
#439

@harm-nomden-sweco
Copy link

What about time dependent control levels for the DiscreteControl?

@visr
Copy link
Member Author

visr commented Mar 14, 2024

That would also be nice to have, but implementation wise is quite different from this issue. Right now we only support control_state in the static tables. See also #298.

@SnippenE SnippenE changed the title Support time dependent parameters for all node types Support time dependent parameters for pump and outlet types May 2, 2024
@visr visr removed the improvement label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
physics Physical process representation
Projects
Status: To do
Development

No branches or pull requests

5 participants