Add Equality Constraints ROS Interface #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Apply formatting. * Replace weld constraint relpose quaternion with valid quaternion. * Add verification of mjNEQDATA, mjNIMP and mjNREF constants. * Fix EQC id fetching. * Add failcase strings for more information to gtest EXPECT macros. * Fix expected content of eq_data for weld constraint.
* Replaced prev quaternion with valid normalized quaternion. * Fixed wrong access of solimp and solref arrays (missing mult). * Add verification that parameters change through service call. * Add string information on failed tests. * Fix EQ id retrieval.
* Fix switch case values and replaced with enum values for consistency. * Fix eq_solimp and eq_solref array access (missing mult). * Fix setting content of eq_data for weld constraints (swapped anchor and relpose[0:3])
Fixes analogous to Set callback
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
DavidPL1
force-pushed
the
noetic-devel
branch
from
a2f302f to
b38ba30
Compare
DavidPL1
force-pushed
the
noetic-devel
branch
from
b38ba30 to
20de064
Compare
DavidPL1
force-pushed
the
noetic-devel
branch
from
3ad8054 to
7f9078c
Compare
DavidPL1
force-pushed
the
noetic-devel
branch
from
7f9078c to
0850dfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test for GHA on PR
Checklist