[datadog_synthetics_test] Fix steps reordering without local_key
#2795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drarig29
force-pushed
the
corentin.girard/SYNTH-17998/fix-steps-reordering-without-local-key
branch
from
b25eff5 to
6f74c46
Compare
teodor2312
approved these changes
Jan 23, 2025
| } | ||
|
|
||
| func createSyntethicsBrowserStepMLElement(uniq string) string { |
There was a problem hiding this comment.
lol i was looking at the diff and it still took me like 30sec to figure out what's the difference 😂
nkzou
approved these changes
Jan 23, 2025
nkzou
deleted the
corentin.girard/SYNTH-17998/fix-steps-reordering-without-local-key
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terraform applying a browser test with provider version v3.51.0 and steps that do not have a
local_keyoverwrites theelementof all steps to the last step’selement.This is caused by #2741, which compares
local_keys together, but doesn't check that they are different than"", which is the default value.You can see the proof that updated tests would fail without the change: here