[datadog_synthetics_test] update the step params when reordering steps #2741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etnbrd
force-pushed
the
etnbrd/SYNTH-14958/allow-browser-steps-reordering
branch
9 times, most recently
from
e2c16ed to
ab77427
Compare
etnbrd
changed the title
etnbrd
force-pushed
the
etnbrd/SYNTH-14958/allow-browser-steps-reordering
branch
from
ab77427 to
f0099c6
Compare
estherk15
previously approved these changes
Dec 27, 2024
nkzou
changed the title
teodor2312
approved these changes
Jan 6, 2025
amaskara-dd
approved these changes
Jan 6, 2025
|
/merge |
Devflow running:
|
dd-devflow
bot
added
mergequeue-status: queued
and removed
mergequeue-status: queued
labels
dd-mergequeue
bot
deleted the
etnbrd/SYNTH-14958/allow-browser-steps-reordering
branch
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When conciliating the config and the state, the provider is not updating the multiLocator (ML) in the state as a side effect of the
diffSuppressFunc, but it nonetheless updates the other fields. So after reordering the steps in the config, the state contains steps with mixed up MLs. This propagates to the crafted request to update the test on the backend, and eventually mess up the remote test.To fix this issue, this PR allows the user to provide a local key for each step to track steps when reordering.
The provider can use this local key to reconcile the right ML into the right step.