Fixes and helpers to handle defaults in nested blocks with oneOf constraints #2700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktmq
approved these changes
Nov 27, 2024
skarimo
merged commit 50b99fa
into
katie.mckew/awsmc-1070-aws-v2-terraform-provider-2
4 checks passed
jack-edmonds-dd
pushed a commit
that referenced
this pull request
Dec 13, 2024
…t` resource (#2682) * WIP * Remove support for namespace_filters.include/exclude_all * Fix validation and refactor * Add tests and upate example * Set list attributes to optional/computed * Fixes and helpers to handle defaults in nested blocks with oneOf constraints (#2700) * renames * type changes * remove bunch of computed * handle some top level * few more defaults * add helper func to remove defaults when in oneOF * Rename resource to datadog_integration_aws_account and fix test * Fix secret_access_key and add key-based account test * Add regex validators, cleanup resource validators * Update import and example and add deprecation message to old resources * Add missing resource * docs * fix cassettes * add default for tags * Update docs/resources/integration_aws_account.md Co-authored-by: Michael Cretzman <[email protected]> * Exclude from generate-docs and manually edit docs to move auth_config under required fields * Rework docs on migrating from v1 and import command * Update docs --------- Co-authored-by: skarimo <[email protected]> Co-authored-by: Sherzod Karimov <[email protected]> Co-authored-by: Michael Cretzman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.