Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[datadog_integration_aws_account] Add datadog_integration_aws_account resource #2682

Merged

Conversation

ktmq
Copy link
Contributor

@ktmq ktmq commented Nov 19, 2024

Adds new datadog_integration_aws_account resource that utilizes the datadogV2 AWS Integrations V2 API.

This resource is meant to replace the following resources from our v1 provider:

  • datadog_integration_aws - all existing functionality (auth config, regions config, metrics collection, metrics namespace filters, resource collection, account tags) is covered in the new resource
  • datadog_integration_aws_lambda_arn - made redundant now that the datadog_aws_account_v2 account resource includes logs_config.lambda_forwarder.lambdas as a sub-field
  • datadog_integration_aws_log_collection - made redundant now that the datadog_aws_account_v2 account resource includes logs_config.lambda_forwarder.sources as a sub-field
  • datadog_integration_aws_tag_filter - made redundant now that the datadog_aws_account_v2 account resource includes metrics_config.tag_filters as a sub-field

@ktmq ktmq changed the title AWS Integrations v2 terraform resource Add AWS Integrations V2 datadog_integration_aws_account resource Dec 9, 2024
@ktmq ktmq marked this pull request as ready for review December 9, 2024 17:36
@ktmq ktmq requested review from a team as code owners December 9, 2024 17:36
nkzou
nkzou previously approved these changes Dec 10, 2024
@skarimo skarimo changed the title Add AWS Integrations V2 datadog_integration_aws_account resource [datadog_integration_aws_account] Add datadog_integration_aws_account resource Dec 12, 2024
@skarimo skarimo requested a review from a team as a code owner December 12, 2024 19:34
skarimo
skarimo previously approved these changes Dec 12, 2024
### Optional

- `account_tags` (List of String) Tags to apply to all metrics in the account
- `auth_config` (Block, Optional) (see [below for nested schema](#nestedblock--auth_config))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't optional :( are we able to manually override/edit this so it can say required in our docs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this to the generate-docs exclusion list so we can fix this

cswatt
cswatt previously approved these changes Dec 12, 2024
Copy link
Contributor

@michaelcretzman michaelcretzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one minor suggestion

docs/resources/integration_aws_account.md Outdated Show resolved Hide resolved
@ktmq ktmq dismissed stale reviews from michaelcretzman, cswatt, and skarimo via b2ae0b0 December 13, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants