Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci-visibility] Add "ci_visibility" Property and "ci-test" Session Type #49

Merged
merged 2 commits into from
Dec 7, 2021
Merged

[ci-visibility] Add "ci_visibility" Property and "ci-test" Session Type #49

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4768d9f
[ci-visibility] add ci_visibility property
juan-fernandez Dec 2, 2021
dd523ed
update session type enum
juan-fernandez Dec 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion schemas/_common-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"type": {
"type": "string",
"description": "Type of the session",
"enum": ["user", "synthetics"],
"enum": ["user", "synthetics", "ci-test"],
Copy link
Contributor

@bcaudan bcaudan Dec 7, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about having the same wording for both session type and extra context key?
ci_visibility VS ci-test

"readOnly": true
},
"has_replay": {
Expand Down Expand Up @@ -180,6 +180,19 @@
},
"readOnly": true
},
"ci_visibility": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how this section (property) would be used from let's say mobile sdk perspective ? Is this meant to be used on all platforms ?

Copy link
Contributor Author

@juan-fernandez juan-fernandez Dec 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hadn't thought about it, but yeah, I don't see why not, there is no technology leakage. We currently use the trace id for the cypress poc, which could be reused for others

"type": "object",
"description": "CI Visibility properties",
"required": ["test_execution_id"],
"properties": {
"test_execution_id": {
"type": "string",
"description": "The identifier of the current CI Visibility test execution",
"readOnly": true
}
},
"readOnly": true
},
"_dd": {
"type": "object",
"description": "Internal properties",
Expand Down