[ci-visibility] Add "ci_visibility" Property and "ci-test" Session Type
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
mariusc83
reviewed
Dec 2, 2021
| @@ -180,6 +180,19 @@ | |||
| }, | |||
| "readOnly": true | |||
| }, | |||
| "ci_visibility": { | |||
There was a problem hiding this comment.
I wonder how this section (property) would be used from let's say mobile sdk perspective ? Is this meant to be used on all platforms ?
There was a problem hiding this comment.
I hadn't thought about it, but yeah, I don't see why not, there is no technology leakage. We currently use the trace id for the cypress poc, which could be reused for others
bcaudan
approved these changes
Dec 6, 2021
mariusc83
approved these changes
Dec 6, 2021
Manu-Tran
approved these changes
Dec 6, 2021
juan-fernandez
changed the title
ci_visibility Propertyci_visibility Property and 'ci-test' Session Type
bcaudan
reviewed
Dec 7, 2021
| @@ -45,7 +45,7 @@ | |||
| "type": { | |||
| "type": "string", | |||
| "description": "Type of the session", | |||
| "enum": ["user", "synthetics"], | |||
| "enum": ["user", "synthetics", "ci-test"], | |||
There was a problem hiding this comment.
what about having the same wording for both session type and extra context key?
ci_visibility VS ci-test
juan-fernandez
changed the title
ci_visibility Property and 'ci-test' Session Type"ci_visibility" Property and "ci-test" Session Type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: DataDog/browser-sdk#1192
ci_visibilityproperty.'ci-test'