Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [RUM-5001] Enforce localStorage usage telemetry #238

Merged
merged 6 commits into from
Jan 3, 2025
Merged

✨ [RUM-5001] Enforce localStorage usage telemetry #238

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e1bee7f
add new property for session storage fallback selection
RomanGaignault Dec 13, 2024
b886f6f
sample update
RomanGaignault Dec 13, 2024
2191a64
update array to string enum
RomanGaignault Dec 16, 2024
32b8e92
remove 'cookie-fallback-to-local-storage' for now
BenoitZugmeyer Jan 3, 2025
c404a07
restore allow_fallback_to_local_storage
BenoitZugmeyer Jan 3, 2025
05f5716
rename sessionStorage to sessionPersistence
BenoitZugmeyer Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/cjs/generated/telemetry.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,9 @@ export declare type TelemetryConfigurationEvent = CommonTelemetryProperties & {
*/
use_secure_session_cookie?: boolean;
/**
* Whether it is allowed to use LocalStorage when cookies are not available
* Configure the storage strategy for sessions.
*/
allow_fallback_to_local_storage?: boolean;
session_storage?: ('cookie' | 'local-storage')[];
/**
* Whether contexts are stored in local storage
*/
Expand Down
4 changes: 2 additions & 2 deletions lib/esm/generated/telemetry.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,9 @@ export declare type TelemetryConfigurationEvent = CommonTelemetryProperties & {
*/
use_secure_session_cookie?: boolean;
/**
* Whether it is allowed to use LocalStorage when cookies are not available
* Configure the storage strategy for sessions.
*/
allow_fallback_to_local_storage?: boolean;
session_storage?: ('cookie' | 'local-storage')[];
/**
* Whether contexts are stored in local storage
*/
Expand Down
2 changes: 1 addition & 1 deletion samples/telemetry-events/configuration.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"track_long_task": true,
"use_cross_site_session_cookie": false,
"use_secure_session_cookie": true,
"allow_fallback_to_local_storage": true,
"session_storage": ["cookie", "local-storage"],
"action_name_attribute": "foo",
"use_allowed_tracing_origins": false,
"default_privacy_level": "mask",
Expand Down
10 changes: 7 additions & 3 deletions schemas/telemetry/configuration-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,13 @@
"type": "boolean",
"description": "Whether a secure session cookie is used"
},
"allow_fallback_to_local_storage": {
"type": "boolean",
"description": "Whether it is allowed to use LocalStorage when cookies are not available"
"session_storage": {
"type": "array",
"items": {
"type": "string",
"enum": ["cookie", "local-storage"]
},
"description": "Configure the storage strategy for sessions."
},
"store_contexts_across_pages": {
"type": "boolean",
Expand Down
Loading