✨ [RUM-5001] Enforce localStorage usage telemetry #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgouchet
previously approved these changes
Dec 16, 2024
xgouchet
previously approved these changes
Dec 17, 2024
sessionStorage is already a DOM/JS concept, so let's use something else
amortemousque
approved these changes
Jan 3, 2025
cy-moi
approved these changes
Jan 3, 2025
BenoitZugmeyer
deleted the
romanG/add-telemetry-enforce-local-storage-property
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed we would like to enforce localstorage by allowing to select session storage
sessionStorage: ["cookie", "local-storage"] → use cookie, fallback to local storage
sessionStorage: ["local-storage"] → never use cookies
sessionStorage: [] → disable session storage
So deprecate old allow_fallback_to_local_storage and add session_storage property for telemetry