Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable generic tags feature #9853

Closed
wants to merge 16 commits into from
Closed

disable generic tags feature #9853

wants to merge 16 commits into from

Conversation

hithwen
Copy link
Contributor

@hithwen hithwen commented Aug 5, 2021 •
edited
Loading

When reviewing focus on:

  • datadog_checks_base/datadog_checks/base/checks/base.py
  • datadog_checks_dev/datadog_checks/dev/tooling/templates/configuration/instances/default.yaml
  • datadog_checks_base/tests/base/checks/test_agent_check.py

The rest are updated config models

Notes:

  • Cilium is a known broken test, we're tracking it's fix on AI-1650
  • Mongo has a known flake, tracked on AI-1770

@hithwen hithwen requested review from a team as code owners August 5, 2021 12:52
This was referenced Aug 5, 2021
Closed
Merged
@codecov
Copy link

codecov bot commented Aug 5, 2021 •
edited
Loading

Codecov Report

Merging #9853 (b96470a) into master (f035348) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Flag Coverage Δ
crio 100.00% <ø> (ø)
external_dns 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@hithwen hithwen requested review from a team as code owners August 6, 2021 10:54
djmitche
djmitche previously approved these changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@djmitche djmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is a prefix of the commits in #9854, so same r+ for the agent-core CODEOWNERS files.

@hithwen hithwen requested a review from ofek August 23, 2021 08:43
@hithwen
Copy link
Contributor Author

hithwen commented Aug 23, 2021 •
edited
Loading

What do you mean by

so same r+ for the agent-core CODEOWNERS files.

?

@djmitche
Copy link
Contributor

Sorry to be unclear. I meant that I was reiterating my review from #9854 since the changes seem identical, and that the review only applies to files owned by agent-core (my team).

coignetp
coignetp requested changes Sep 1, 2021
View reviewed changes
Copy link
Contributor

@coignetp coignetp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit

datadog_checks_dev/datadog_checks/dev/tooling/templates/configuration/instances/default.yaml Outdated Show resolved Hide resolved
@hithwen hithwen requested a review from coignetp September 1, 2021 09:48
@hithwen hithwen mentioned this pull request Sep 2, 2021
Merged
@hithwen
Copy link
Contributor Author

hithwen commented Sep 2, 2021

Closing in favour of #10027

@hithwen hithwen closed this Sep 2, 2021
@ofek ofek deleted the js/generic-tags-feature branch September 2, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djmitche djmitche djmitche left review comments

@ofek ofek Awaiting requested review from ofek

@coignetp coignetp Awaiting requested review from coignetp

Assignees
No one assigned
Labels
integration/amazon_msk integration/apache integration/cassandra_nodetool integration/cassandra integration/consul integration/datadog_checks_base integration/datadog_checks_dev integration/dd_cluster_agent integration/directory integration/elastic integration/envoy integration/gitlab_runner integration/glusterfs integration/go_expvar integration/gunicorn integration/haproxy integration/harbor integration/http_check integration/ibm_mq integration/istio integration/kafka_consumer integration/kafka integration/mapr integration/mesos_master integration/mesos_slave integration/mysql integration/nagios integration/network integration/nfsstat integration/nginx_ingress_controller integration/nginx integration/openldap integration/oracle integration/postfix integration/postgres integration/powerdns_recursor integration/rabbitmq integration/riak integration/riakcs integration/sap_hana integration/sonarqube integration/spark integration/sqlserver integration/squid integration/ssh_check integration/statsd integration/supervisord integration/system_core integration/system_swap integration/tcp_check integration/teamcity integration/tls integration/tomcat integration/twemproxy integration/twistlock integration/varnish integration/vault integration/vertica integration/voltdb integration/vsphere integration/win32_event_log integration/windows_service integration/wmi_check integration/yarn integration/zk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hithwen @djmitche @ofek @coignetp