query manager generic tag mapping

[hithwen]

Depends on

• Add types and docs to query manager #9795
• Split db tests #9814
• Move GENIRC_TAG defintion to checks_base to be used by the query manager #9817
• Make both tagging transformers share interface #9816
  Still needs tests

[codecov]

Codecov Report

Merging #9803 (aeb6586) into master (a2b6cd8) will decrease coverage by 0.41%.
The diff coverage is 68.00%.

Flag	Coverage Δ
active_directory	100.00% <ø> (ø)
activemq_xml	82.31% <ø> (ø)
aerospike	86.97% <ø> (+0.36%)	⬆️
airflow	89.94% <ø> (ø)
amazon_msk	87.94% <ø> (ø)
ambari	86.98% <ø> (ø)
apache	95.43% <ø> (ø)
aspdotnet	93.87% <ø> (ø)
azure_iot_edge	82.01% <ø> (ø)
btrfs	82.91% <ø> (ø)
cacti	83.95% <ø> (ø)
cassandra_nodetool	94.19% <ø> (ø)
ceph	91.02% <ø> (ø)
cilium	85.84% <ø> (+1.88%)	⬆️
cisco_aci	95.88% <ø> (ø)
cloud_foundry_api	95.98% <ø> (+0.12%)	⬆️
cockroachdb	97.18% <ø> (ø)
consul	91.74% <ø> (ø)
coredns	96.36% <ø> (ø)
couch	95.19% <ø> (+0.24%)	⬆️
couchbase	81.45% <ø> (ø)
crio	100.00% <ø> (ø)
datadog_checks_dev	79.93% <ø> (ø)
datadog_checks_downloader	80.64% <ø> (ø)
datadog_cluster_agent	97.50% <ø> (ø)
directory	94.70% <ø> (ø)
disk	91.00% <ø> (-0.51%)	⬇️
dns_check	94.00% <ø> (ø)
dotnetclr	100.00% <ø> (ø)
druid	97.70% <ø> (ø)
ecs_fargate	77.65% <ø> (ø)
eks_fargate	94.05% <ø> (ø)
elastic	88.54% <ø> (ø)
envoy	93.77% <ø> (+0.25%)	⬆️
etcd	93.09% <ø> (ø)
exchange_server	100.00% <ø> (ø)
external_dns	100.00% <ø> (ø)
fluentd	94.77% <ø> (ø)
gearmand	77.27% <ø> (+1.29%)	⬆️
gitlab	89.94% <ø> (ø)
gitlab_runner	90.32% <ø> (ø)
glusterfs	80.09% <ø> (+0.92%)	⬆️
go_expvar	91.95% <ø> (ø)
gunicorn	94.29% <ø> (ø)
haproxy	95.22% <ø> (+0.17%)	⬆️
harbor	91.58% <ø> (ø)
hazelcast	92.39% <ø> (ø)
hdfs_datanode	90.00% <ø> (ø)
hdfs_namenode	87.94% <ø> (ø)
http_check	89.96% <ø> (+1.82%)	⬆️
ibm_db2	93.65% <ø> (ø)
ibm_mq	90.00% <ø> (-0.19%)	⬇️
ibm_was	97.44% <ø> (ø)
iis	93.01% <ø> (ø)
istio	93.25% <ø> (+0.56%)	⬆️
kafka_consumer	80.95% <ø> (ø)
kong	92.21% <ø> (ø)
kube_apiserver_metrics	97.35% <ø> (ø)
kube_controller_manager	97.14% <ø> (ø)
kube_dns	98.85% <ø> (ø)
kube_metrics_server	100.00% <ø> (ø)
kube_proxy	100.00% <ø> (ø)
kube_scheduler	96.41% <ø> (ø)
kubelet	89.47% <ø> (ø)
kubernetes_state	89.69% <ø> (ø)
kyototycoon	85.96% <ø> (ø)
lighttpd	83.64% <ø> (ø)
linkerd	86.12% <ø> (+1.15%)	⬆️
linux_proc_extras	96.22% <ø> (ø)
mapr	82.53% <ø> (ø)
mapreduce	82.27% <ø> (ø)
marathon	83.12% <ø> (ø)
marklogic	95.32% <ø> (ø)
mcache	93.39% <ø> (ø)
mesos_master	89.68% <ø> (ø)
mesos_slave	93.63% <ø> (ø)
mongo	94.74% <ø> (+0.28%)	⬆️
mysql	85.28% <ø> (+0.14%)	⬆️
nagios	89.53% <ø> (ø)
network	77.76% <ø> (+1.00%)	⬆️
nfsstat	95.20% <ø> (ø)
nginx	95.11% <ø> (+0.93%)	⬆️
nginx_ingress_controller	98.30% <ø> (ø)
openldap	96.33% <ø> (ø)
openmetrics	97.14% <ø> (ø)
openstack	51.30% <ø> (ø)
openstack_controller	90.51% <ø> (ø)
pdh_check	97.77% <ø> (ø)
pgbouncer	91.50% <ø> (ø)
php_fpm	90.04% <ø> (+0.43%)	⬆️
postfix	88.04% <ø> (ø)
postgres	92.21% <ø> (+0.29%)	⬆️
powerdns_recursor	95.93% <ø> (ø)
process	85.12% <ø> (ø)
prometheus	94.17% <ø> (ø)
rabbitmq	93.73% <ø> (ø)
redisdb	87.26% <ø> (+0.31%)	⬆️
riak	99.22% <ø> (ø)
riakcs	93.61% <ø> (ø)
sap_hana	93.04% <ø> (ø)
scylla	100.00% <ø> (ø)
snmp	91.20% <ø> (+0.04%)	⬆️
sonarqube	95.69% <ø> (ø)
spark	93.46% <ø> (ø)
sqlserver	67.25% <ø> (-14.49%)	⬇️
squid	100.00% <ø> (ø)
ssh_check	91.08% <ø> (ø)
statsd	87.36% <ø> (+1.05%)	⬆️
supervisord	92.30% <ø> (ø)
system_core	91.04% <ø> (ø)
system_swap	98.30% <ø> (ø)
tcp_check	87.95% <ø> (ø)
teamcity	80.00% <ø> (ø)
tls	97.04% <ø> (+0.87%)	⬆️
tokumx	58.40% <ø> (?)
twemproxy	78.33% <ø> (ø)
twistlock	80.74% <ø> (ø)
varnish	84.57% <ø> (+0.24%)	⬆️
vault	94.91% <ø> (+0.53%)	⬆️
vertica	92.30% <ø> (ø)
vsphere	89.77% <ø> (+0.08%)	⬆️
win32_event_log	86.03% <ø> (+0.28%)	⬆️
windows_service	95.83% <ø> (ø)
wmi_check	92.91% <ø> (ø)
yarn	90.30% <ø> (ø)
zk	85.17% <ø> (+0.25%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[ofek]

I think we should not modify the database utils at all and instead add your logic here:

integrations-core/datadog_checks_base/datadog_checks/base/checks/base.py

Lines 1068 to 1075 in d96a2de

	def _normalize_tags_type(self, tags, device_name=None, metric_name=None):
	# type: (Sequence[Union[None, str, bytes]], str, str) -> List[str]
	"""
	Normalize tags contents and type:
	- append `device_name` as `device:` tag
	- normalize tags type
	- doesn't mutate the passed list, returns a new list
	"""

[hithwen]

Replaced by #9853