implement iis as pdh check #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekwbrown
force-pushed
the
db/iis_pdh
branch
15 times, most recently
from
b9d2a52 to
ea63ad2
Compare
Update example config. Allow for querying all sites. Add capability for adding additional metrics not already collected Switch to dd-agent branch which has required libs; remove this change when that branch is merged Fix adding too many service checks dd-agent now has correct libs Add proper handing of 'TOTAL'
derekwbrown
force-pushed
the
db/iis_pdh
branch
from
ea63ad2 to
f4fe925
Compare
gmmeyer
previously approved these changes
Dec 12, 2017
appveyor.yml
Outdated
| @@ -8,7 +8,7 @@ environment: | |||
| NOSE_FILTER: not unix and not fixme and not winfixme | |||
| PYWIN_PATH: C:\projects\integrations-core\.cache\pywin32-py2.7.exe | |||
| SKIP_LINT: true | |||
| DD_AGENT_BRANCH: master | |||
| DD_AGENT_BRANCH: db/pdh_base_updates | |||
There was a problem hiding this comment.
can you change this back?
iis/check.py
Outdated
| # don't give up on all of the metrics because one failed | ||
| self.log.error("IIS Failed to get data for %s %s: %s" % (inst_name, dd_name, str(e))) | ||
| pass | ||
| self.log.debug("expected sites is now %s" % str(expected_sites)) |
There was a problem hiding this comment.
Can you change this to make it a bit more informative? Something like "failed to grab metrics for...", so that we don't have to know the internal code of the check to interpret it.
Additional questions:
Do we want to log this on info?
Do we want to log it on warning, so it shows up on the info page?
derekwbrown
force-pushed
the
db/iis_pdh
branch
from
05c6ecc to
ed363bb
Compare
gmmeyer
approved these changes
Dec 18, 2017
There was a problem hiding this comment.
@derekwbrown I think this is good to go. I reran the tests, we'll wait for them to finish. Unless you think there's some reason to sit on this, let's merge it.
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo iis check as PDH rather than WMI.
Update example config.
Allow for querying all sites.
Add capability for adding additional metrics not already collected
Requires PDH support in 5.22/6.0+