Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdh_check has a typo causing tags to not work as intended #940

Closed
nvecellio opened this issue Dec 14, 2017 · 2 comments
Closed

pdh_check has a typo causing tags to not work as intended #940

nvecellio opened this issue Dec 14, 2017 · 2 comments
Assignees
Milestone

Comments

@nvecellio
Copy link

https://github.com/DataDog/integrations-core/blob/master/pdh_check/check.py#L65

                if not counter.is_single_instance():
                    tag = "instance=%s" % key
                    tags.append(tag)

The "=" character causes tags to show in the UI as just a value, and not a key:value, making it more difficult to graph these metrics. A simple change to ":" causes these tags to work as expected.

@masci masci added this to the 5.21 milestone Dec 15, 2017
@derekwbrown
Copy link
Contributor

Was resolved in #927

@derekwbrown
Copy link
Contributor

Integration fixed with proper tagging in PR #927

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants