Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kafka_consumer_group_ConsumerLagMetrics_Value metric #9027

Merged
merged 3 commits into from
Mar 24, 2021
Merged

Add kafka_consumer_group_ConsumerLagMetrics_Value metric #9027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5125486
Add kafka_consumer_group_ConsumerLagMetrics_Value to collected metrics
idarlington Mar 24, 2021
1be5c01
Merge branch 'master' of https://github.com/DataDog/integrations-core
idarlington Mar 24, 2021
0d323ef
Update test jmx_metrics.txt
idarlington Mar 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions amazon_msk/datadog_checks/amazon_msk/metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
'jmx_scrape_duration_seconds': 'jmx.scrape.duration.seconds',
'jmx_scrape_error': 'jmx.scrape.error',
'kafka_cluster_Partition_Value': 'kafka.cluster.Partition.Value',
'kafka_consumer_group_ConsumerLagMetrics_Value': 'kafka.consumer.group.ConsumerLagMetrics.Value',
'kafka_controller_ControllerChannelManager_50thPercentile': (
'kafka.controller.ControllerChannelManager.50thPercentile'
),
Expand Down Expand Up @@ -532,6 +533,7 @@
}
JMX_METRICS_OVERRIDES = {
'kafka_cluster_Partition_Value': 'gauge',
'kafka_consumer_group_ConsumerLagMetrics_Value': 'gauge',
'kafka_controller_ControllerChannelManager_50thPercentile': 'gauge',
'kafka_controller_ControllerChannelManager_75thPercentile': 'gauge',
'kafka_controller_ControllerChannelManager_95thPercentile': 'gauge',
Expand Down
1 change: 1 addition & 0 deletions amazon_msk/metadata.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ aws.msk.jmx.exporter.build.info,gauge,,,,A metric with a constant '1' value labe
aws.msk.jmx.scrape.duration.seconds,gauge,,second,,"Time this JMX scrape took, in seconds.",0,amazon_kafka,
aws.msk.jmx.scrape.error,gauge,,,,Non-zero if this scrape failed.,0,amazon_kafka,
aws.msk.kafka.cluster.Partition.Value,gauge,,,,"Attribute exposed for management (kafka.cluster<type=Partition, name=InSyncReplicasCount, topic=test-topic-15, partition=70><>Value)",0,amazon_kafka,
aws.msk.kafka.consumer.group.ConsumerLagMetrics.Value,gauge,,,,"Attribute exposed for management (kafka.consumer.group<type=ConsumerLagMetrics, name=EstimatedTimeLag, groupId=test-group, partition=1, topic=test-topic><>Value)",0,amazon_kafka,
aws.msk.kafka.controller.ControllerChannelManager.50thPercentile,gauge,,,,"Attribute exposed for management (kafka.controller<type=ControllerChannelManager, name=RequestRateAndQueueTimeMs, broker-id=1><>50thPercentile)",0,amazon_kafka,
aws.msk.kafka.controller.ControllerChannelManager.75thPercentile,gauge,,,,"Attribute exposed for management (kafka.controller<type=ControllerChannelManager, name=RequestRateAndQueueTimeMs, broker-id=1><>75thPercentile)",0,amazon_kafka,
aws.msk.kafka.controller.ControllerChannelManager.95thPercentile,gauge,,,,"Attribute exposed for management (kafka.controller<type=ControllerChannelManager, name=RequestRateAndQueueTimeMs, broker-id=1><>95thPercentile)",0,amazon_kafka,
Expand Down
28 changes: 28 additions & 0 deletions amazon_msk/tests/fixtures/jmx_metrics.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14595,6 +14595,34 @@ kafka_cluster_Partition_Value{name="UnderReplicated",topic="test-topic-2",partit
kafka_cluster_Partition_Value{name="InSyncReplicasCount",topic="test-topic-11",partition="54",} 3.0
kafka_cluster_Partition_Value{name="InSyncReplicasCount",topic="test-topic-3",partition="88",} 3.0
kafka_cluster_Partition_Value{name="LastStableOffsetLag",topic="test-topic-13",partition="79",} 0.0
# TYPE kafka_consumer_group_ConsumerLagMetrics_Value untyped
kafka_consumer_group_ConsumerLagMetrics_Value{groupId="test-group-1",name="EstimatedTimeLag",partition="1",topic="test-topic"} 0.0
kafka_consumer_group_ConsumerLagMetrics_Value{groupId="test-group-1",name="SumOffsetLag",topic="test-topic"} 0.0
kafka_consumer_group_ConsumerLagMetrics_Value{groupId="test-group-1",name="OffsetLag",partition="0",topic="test-topic"} 0.0
kafka_consumer_group_ConsumerLagMetrics_Value{groupId="test-group-1",name="MaxOffsetLag",topic="test-topic"} 0.0
kafka_consumer_group_ConsumerLagMetrics_Value{groupId="test-group-2",name="EstimatedTimeLag",partition="0",topic="test-topic"} 0.0
kafka_consumer_group_ConsumerLagMetrics_Value{groupId="test-group-3",name="MaxOffsetLag",topic="test-topic"} 0.0
kafka_consumer_group_ConsumerLagMetrics_Value{groupId="test-group-2",name="MaxOffsetLag",topic="test-topic"} 0.0
kafka_consumer_group_ConsumerLagMetrics_Value{groupId="test-group-1",name="EstimatedMaxTimeLag",topic="test-topic"} 0.0
kafka_consumer_group_ConsumerLagMetrics_Value{groupId="test-group-1",name="EstimatedTimeLag",partition="0",topic="test-topic"} 0.0
kafka_consumer_group_ConsumerLagMetrics_Value{groupId="test-group-1",name="OffsetLag",partition="2",topic="test-topic"} 0.0
kafka_consumer_group_ConsumerLagMetrics_Value{groupId="test-group-1",name="OffsetLag",partition="1",topic="test-topic"} 0.0
kafka_consumer_group_ConsumerLagMetrics_Value{groupId="test-group-3",name="EstimatedTimeLag",partition="0",topic="test-topic"} 0.0
kafka_consumer_group_ConsumerLagMetrics_Value{groupId="test-group-3",name="OffsetLag",partition="2",topic="test-topic"} 0.0
kafka_consumer_group_ConsumerLagMetrics_Value{groupId="test-group-3",name="SumOffsetLag",topic="test-topic"} 0.0
kafka_consumer_group_ConsumerLagMetrics_Value{groupId="test-group-3",name="OffsetLag",partition="0",topic="test-topic"} 0.0
kafka_consumer_group_ConsumerLagMetrics_Value{groupId="test-group-3",name="EstimatedTimeLag",partition="2",topic="test-topic"} 0.0
kafka_consumer_group_ConsumerLagMetrics_Value{groupId="test-group-3",name="EstimatedMaxTimeLag",topic="test-topic"} 0.0
kafka_consumer_group_ConsumerLagMetrics_Value{groupId="test-group-3",name="EstimatedTimeLag",partition="1",topic="test-topic"} 0.0
kafka_consumer_group_ConsumerLagMetrics_Value{groupId="test-group-3",name="OffsetLag",partition="1",topic="test-topic"} 0.0
kafka_consumer_group_ConsumerLagMetrics_Value{groupId="test-group-2",name="EstimatedMaxTimeLag",topic="test-topic"} 0.0
kafka_consumer_group_ConsumerLagMetrics_Value{groupId="test-group-2",name="OffsetLag",partition="2",topic="test-topic"} 0.0
kafka_consumer_group_ConsumerLagMetrics_Value{groupId="test-group-2",name="OffsetLag",partition="0",topic="test-topic"} 0.0
kafka_consumer_group_ConsumerLagMetrics_Value{groupId="test-group-2",name="EstimatedTimeLag",partition="2",topic="test-topic"} 0.0
kafka_consumer_group_ConsumerLagMetrics_Value{groupId="test-group-2",name="SumOffsetLag",topic="test-topic"} 0.0
kafka_consumer_group_ConsumerLagMetrics_Value{groupId="test-group-2",name="EstimatedTimeLag",partition="1",topic="test-topic"} 0.0
kafka_consumer_group_ConsumerLagMetrics_Value{groupId="test-group-2",name="OffsetLag",partition="1",topic="test-topic"} 0.0
kafka_consumer_group_ConsumerLagMetrics_Value{groupId="test-group-1",name="EstimatedTimeLag",partition="2",topic="test-topic"} 0.0
# HELP kafka_security_SimpleAclAuthorizer_MeanRate Attribute exposed for management (kafka.security<type=SimpleAclAuthorizer, name=ZooKeeperSaslAuthenticationsPerSec><>MeanRate)
# TYPE kafka_security_SimpleAclAuthorizer_MeanRate untyped
kafka_security_SimpleAclAuthorizer_MeanRate{name="ZooKeeperSaslAuthenticationsPerSec",} 0.0
Expand Down