Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kafka_consumer_group_ConsumerLagMetrics_Value metric #9027

Merged
merged 3 commits into from
Mar 24, 2021
Merged

Add kafka_consumer_group_ConsumerLagMetrics_Value metric #9027

merged 3 commits into from
Mar 24, 2021

Conversation

idarlington
Copy link
Contributor

@idarlington idarlington commented Mar 24, 2021 •
edited
Loading

What does this PR do?

Adds kafka_consumer_group_ConsumerLagMetrics_Value to metrics scraped by the amazon msk agent. This metric was missing and is important in monitoring consumer lag.

Motivation

This is an important metric for monitoring applications using MSK. It is used for monitoring offset lag in Kafka.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@idarlington idarlington requested a review from a team as a code owner March 24, 2021 19:10
@idarlington
Copy link
Contributor Author

@ChristineTChen @ofek please review

ofek
ofek approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ofek ofek changed the title Add kafka_consumer_group_ConsumerLagMetrics_Value to amazon MSK metrics Add kafka_consumer_group_ConsumerLagMetrics_Value metric Mar 24, 2021
@idarlington
Copy link
Contributor Author

💯

Please can you also add the label ; can't seem to add that.

PR must have changelog/ and integration/ labels attached

ChristineTChen
ChristineTChen approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@ChristineTChen ChristineTChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ofek ofek merged commit 54f6ede into DataDog:master Mar 24, 2021
@ChristineTChen
Copy link
Contributor

Hey @idarlington , you can upgrade the integration to 1.5.0 for this metric support:

sudo -u dd-agent -- datadog-agent integration install datadog-amazon-msk==1.5.0

https://docs.datadoghq.com/agent/guide/integration-management/#install

@idarlington
Copy link
Contributor Author

Nice! Thanks @ChristineTChen @ofek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristineTChen ChristineTChen ChristineTChen approved these changes

@ofek ofek ofek approved these changes

Assignees
No one assigned
Labels
integration/amazon_msk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@idarlington @ChristineTChen @ofek