Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync openmetrics config specs with new option ignore_metrics_by_labels #7823

Merged
merged 8 commits into from
Oct 29, 2020
Merged

Sync openmetrics config specs with new option ignore_metrics_by_labels #7823

merged 8 commits into from
Oct 29, 2020

Conversation

ChristineTChen
Copy link
Contributor

What does this PR do?

Adds config option introduced in this PR: #7822

Motivation

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@ChristineTChen ChristineTChen requested review from a team as code owners October 20, 2020 19:59
@codecov
Copy link

codecov bot commented Oct 21, 2020 •
edited
Loading

Codecov Report

Merging #7823 into master will decrease coverage by 0.97%.
The diff coverage is n/a.

Impacted Files Coverage Δ
directory/datadog_checks/directory/directory.py
system_core/datadog_checks/system_core/__init__.py
system_core/tests/common.py
couch/tests/common.py
directory/tests/conftest.py
hivemq/datadog_checks/hivemq/__about__.py
confluent_platform/tests/conftest.py
lighttpd/datadog_checks/lighttpd/__init__.py
mesos_master/tests/test_integration.py
...node/datadog_checks/hdfs_namenode/hdfs_namenode.py
... and 693 more

kayayarai
kayayarai previously approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@kayayarai kayayarai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from Documentation

hithwen
hithwen requested changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@hithwen hithwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to need to bump checks base in all these after #7822 is released

@ChristineTChen ChristineTChen force-pushed the cc/ignore-metric-label-option branch from c8abbcc to 7427f87 Compare October 28, 2020 22:03
@ChristineTChen ChristineTChen merged commit 4efabd4 into master Oct 29, 2020
@ChristineTChen ChristineTChen deleted the cc/ignore-metric-label-option branch October 29, 2020 21:18
@AlexandreYang AlexandreYang mentioned this pull request Nov 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hithwen hithwen hithwen requested changes

@ofek ofek ofek approved these changes

@kayayarai kayayarai kayayarai left review comments

@florimondmanca florimondmanca Awaiting requested review from florimondmanca

Assignees
No one assigned
Labels
dev/tooling integration/amazon_msk integration/cilium integration/cockroachdb integration/coredns integration/crio integration/datadog_checks_dev integration/etcd integration/gitlab_runner integration/gitlab integration/haproxy integration/istio integration/kube_apiserver_metrics integration/kube_scheduler integration/nginx_ingress_controller integration/openmetrics integration/scylla
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ChristineTChen @hithwen @ofek @kayayarai @florimondmanca