Filter metrics by label keys and values #7822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Codecov Report
|
4 tasks
mgarabed
reviewed
Oct 20, 2020
datadog_checks_base/datadog_checks/base/checks/openmetrics/mixins.py
Outdated
Show resolved
Hide resolved
mgarabed
previously approved these changes
Oct 23, 2020
xornivore
previously approved these changes
Oct 27, 2020
| sample_labels = sample[self.SAMPLE_LABELS] | ||
| for label_key, label_values in ignore_metrics_by_label.items(): | ||
| if not label_values: | ||
| self.log.warning( |
There was a problem hiding this comment.
curious if this might be a bit noisy? maybe debug is better?
There was a problem hiding this comment.
that sounds good, updated
ChristineTChen
dismissed stale reviews from xornivore and mgarabed
via
c313716
xornivore
previously approved these changes
Oct 27, 2020
ChristineTChen
force-pushed
the
cc/metric-filter
branch
from
ce92c22 to
6de3a96
Compare
hithwen
approved these changes
Oct 28, 2020
github-actions bot
pushed a commit
that referenced
this pull request
Oct 28, 2020
* Add config option * ignore samples with matching label exclusion * filter all samples * Fix label key check * Fix style * Use plural in option name * Allow for wildcards * Add test for wildcard * Test invalid option value * Update log for invalid label values to warning * Use wildcard in list * Test exact match * Style * Drop warning to debug * Fix test e9343e4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces a config option that allows users to ignore metrics with certain labels or label values.
in conf.yaml
The above will ignore metrics with labels
pid:puma_masteror any metric with labelworker:<ANY>Motivation
FR
Additional Notes
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached