envoy config specs #7157
Merged
envoy config specs #7157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hithwen
force-pushed
the
julia/envoy-config-specs
branch
from
434657e to
0915e57
Compare
FlorianVeaux
approved these changes
Jul 21, 2020
| ## Set path if type is file. | ||
| ## Set channel_path if type is windows_event. | ||
| ## source - required - Attribute that defines which Integration sent the logs. | ||
| ## service - required - The name of the service that generates the log. |
There was a problem hiding this comment.
Any way to remove that comment as service is not required anymore?
| ## This overrides the `proxy` setting in `init_config`. | ||
| ## | ||
| ## Set HTTP or HTTPS proxies. Use the `no_proxy` list | ||
| ## Set HTTP or HTTPS proxies for all instances. Use the `no_proxy` list |
There was a problem hiding this comment.
This is incorrect, it just sets the proxy to the current instance. But this should be fixed in a separate PR.
github-actions bot
pushed a commit
that referenced
this pull request
Jul 21, 2020
* Add config specs * Bump base package requirement 9adfa42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #7156